From: Richard Henderson <rth@twiddle.net>
To: Chen Gang <xili_gchen_5257@hotmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single floating point
Date: Thu, 12 Nov 2015 17:18:31 +0100 [thread overview]
Message-ID: <5644BBD7.4090109@twiddle.net> (raw)
In-Reply-To: <BLU437-SMTP825879E16C5695A00D3B62B9120@phx.gbl>
On 11/12/2015 05:12 PM, Chen Gang wrote:
> On 11/12/15 22:36, Richard Henderson wrote:
>>> + if (sfmt.calc == TILEGX_F_CALC_CVT) {
>>> + if (sfmt.sign)
>>> + f.f = int32_to_float32(0 - sfmt.mantissa, fp_status);
>>> + else
>>> + f.f = uint32_to_float32(sfmt.mantissa, fp_status);
>>> + } else {
>>
>> Formatting.
>>
>> You really should know better by now.
>> I'm not even going to look at the rest.
>>
>
> Excuse me, my English is not quite well, I am not quite understand your
> meaning.
>
> Does the code above have issues?
>
Please read ./CODING_STYLE, and use ./scripts/checkpatch.pl.
r~
next prev parent reply other threads:[~2015-11-12 16:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 5:42 [Qemu-devel] [PATCH 0/4] Implment fpu floating point instructions Chen Gang
2015-11-08 5:43 ` [Qemu-devel] [PATCH 1/4] target-tilegx: Add fpu header file Chen Gang
2015-11-12 14:34 ` Richard Henderson
2015-11-12 16:04 ` Chen Gang
2015-11-12 16:10 ` Peter Maydell
2015-11-12 16:28 ` Chen Gang
2015-11-08 5:44 ` [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single floating point Chen Gang
2015-11-12 14:36 ` Richard Henderson
2015-11-12 16:12 ` Chen Gang
2015-11-12 16:18 ` Richard Henderson [this message]
2015-11-12 16:29 ` Chen Gang
2015-11-08 5:46 ` [Qemu-devel] [PATCH 3/4] target-tilegx: Implement fpu fdouble " Chen Gang
2015-11-08 5:47 ` [Qemu-devel] [PATCH 4/4] target-tilegx: Let fpu implementation code can be built and used Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5644BBD7.4090109@twiddle.net \
--to=rth@twiddle.net \
--cc=cmetcalf@ezchip.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).