qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] -cpu check, rdtscp and AMD KVM
Date: Thu, 12 Nov 2015 17:35:59 +0100	[thread overview]
Message-ID: <5644BFEF.8070909@redhat.com> (raw)
In-Reply-To: <20151112162748.GN4180@thinpad.lan.raisama.net>



On 12/11/2015 17:27, Eduardo Habkost wrote:
>> > > To simply remove rdtscp from all Opteron_G* models?
> > 
> > Not sure this is the right thing to do...  Real hardware has it, and
> > going forward KVM will provide it.
> 
> Do you see any alternative?

Live with the warning, and document it in the release notes.

> We need AMD CPU models that can run
> out of the box using today's kernels. As no existing VMs running
> Opteron_G* on AMD CPUs have rdtscp, I believe it makes sense to
> just define Opteron_G* without rdtscp.
> 
> When we add SVM rdtscp support to KVM, we can add new
> "Opteron_G[2-5]-rdtscp" CPU models.

Makes sense too.

However, I'm a bit afraid of the interaction with libvirt. Right now,
libvirt has rdtscp in the description.  If we remove it from libvirt,
libvirt will start adding +rdtscp to the QEMU CPU command line option,
so our change will be moot.  And if we do not remove it from libvirt,
libvirt will not be able to start a VM with rdtscp on a fixed kernel.

Is this correct?

Paolo

  reply	other threads:[~2015-11-12 16:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 10:53 [Qemu-devel] -cpu check, rdtscp and AMD KVM Paolo Bonzini
2015-11-12 15:25 ` Eduardo Habkost
2015-11-12 15:58   ` Paolo Bonzini
2015-11-12 16:27     ` Eduardo Habkost
2015-11-12 16:35       ` Paolo Bonzini [this message]
2015-11-12 16:48         ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644BFEF.8070909@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).