From: Michael Tokarev <mjt@tls.msk.ru>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Cao jin <caoj.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos
Date: Thu, 12 Nov 2015 21:33:17 +0300 [thread overview]
Message-ID: <5644DB6D.4030308@msgid.tls.msk.ru> (raw)
In-Reply-To: <5644D222.3070408@suse.de>
12.11.2015 20:53, Andreas Färber wrote:
> Am 06.11.2015 um 13:43 schrieb Michael Tokarev:
>> From: Cao jin <caoj.fnst@cn.fujitsu.com>
>>
>> Also change the misleading definition of macro OBJECT_CLASS_CHECK
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>
> Michael, please *STOP* queuing QOM patches! You merged the unfixed
I think I do more harm to the project than good, these days.
> version now - it's supposed to have just "qom:", and the parenthesis and
> full stop are missing, too, that I had on qom-next before it disappeared
> with today's rebase...
>
> And why was I not CC'ed on this submission as include/qom/object.h
> maintainer? You did not reply to the patch either, where I did.
I didn't reply there because I wanted to remove the patch, exactly
because you replied to the thread. It looks like I forgot to remove
it from the -trivial tree.
Now, in the original thread, you said you only tweaked the commit
(subject) message. Is it really that bad in the original submission?
Thanks,
/mjt
next prev parent reply other threads:[~2015-11-12 18:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 12:43 [Qemu-devel] [PULL 00/24] Trivial patches for 2015-11-06 Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 01/24] hw/acpi/aml-build: remove useless glib version check Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 02/24] gdbstub: Fix buffer overflows in gdb_handle_packet() Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 03/24] hw/display/tcx: Remove superfluous OBJECT() typecasts Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 04/24] maint: Ignore ivshmem binaries Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 05/24] fix bad indentation in pcie_cap_slot_write_config() Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 06/24] tests: ignore test-qga Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 07/24] xen: fix invalid assertion Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 08/24] hw/input/tsc210x: Remove superfluous memset Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 09/24] tests/i44fx-test: No need for zeroing memory before memset Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 10/24] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 11/24] hw/dma/pxa2xx: Remove superfluous memset Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 12/24] bt: fix use of uninitialized variable seqlen Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 13/24] ui: Use g_new() & friends where that makes obvious sense Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 14/24] qxl: " Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 15/24] usb: " Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 16/24] configure: remove help string for 'vnc-tls' option Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos Michael Tokarev
2015-11-12 17:53 ` Andreas Färber
2015-11-12 18:33 ` Michael Tokarev [this message]
2015-11-13 7:51 ` Markus Armbruster
2015-11-06 12:43 ` [Qemu-devel] [PULL 18/24] pci-assign: do not test path with access() before opening Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 19/24] ivshmem-server: fix possible OVERRUN Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 20/24] target-alpha: fix uninitialized variable Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 21/24] exec: avoid unnecessary cacheline bounce on ram_list.mru_block Michael Tokarev
2015-11-06 12:43 ` [Qemu-devel] [PULL 22/24] taget-ppc: Fix read access to IBAT registers higher than IBAT3 Michael Tokarev
2015-11-06 12:44 ` [Qemu-devel] [PULL 23/24] qemu-sockets: do not test path with access() before unlinking Michael Tokarev
2015-11-06 12:44 ` [Qemu-devel] [PULL 24/24] tap-bsd: use user-specified tap device if it already exists Michael Tokarev
2015-11-06 13:46 ` [Qemu-devel] [PULL 00/24] Trivial patches for 2015-11-06 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5644DB6D.4030308@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=afaerber@suse.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).