From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwyU3-0000Ec-VS for qemu-devel@nongnu.org; Thu, 12 Nov 2015 15:28:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwyTz-0002wd-1c for qemu-devel@nongnu.org; Thu, 12 Nov 2015 15:28:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwyTy-0002wK-SF for qemu-devel@nongnu.org; Thu, 12 Nov 2015 15:28:34 -0500 References: <1447323728-2427-1-git-send-email-prasanna.kalever@redhat.com> <1447323728-2427-2-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <5644F671.7000301@redhat.com> Date: Thu, 12 Nov 2015 13:28:33 -0700 MIME-Version: 1.0 In-Reply-To: <1447323728-2427-2-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HhiXXVR9VDlWHi43wuKbdquQfDqFHtx51" Subject: Re: [Qemu-devel] [PATCH 1/4] block/gluster: rename [server, volname, image] -> [host, volume, path] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pkrempa@redhat.com, stefanha@gmail.com, jcody@redhat.com, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HhiXXVR9VDlWHi43wuKbdquQfDqFHtx51 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch is very much be meaningful after next patch which adds multi= ple > gluster servers support. After that, >=20 > an example is, in 'servers' tuple values we use 'server' variable for = key Awkward line break mid-sentence. The commit message alone is not a reason to hold up this patch, so maybe the maintainer can adjust it. > 'host' in the code, it will be quite messy to have colliding names for > variables, so to maintain better readability and makes it consistent wi= th other > existing code as well as the input keys/options, this patch renames the= > following variables I'd suggest replacing everything up to here with: A future patch will add support for multiple gluster servers. Our existing terminology is a bit unusual in relation to what names are used by other networked devices, and doesn't map very well to the terminology we expect to use for multiple servers. Therefore, rename the following options: > 'server' -> 'host' > 'image' -> 'path' > 'volname' -> 'volume' >=20 > Signed-off-by: Prasanna Kumar Kalever > Reviewed-by: Eric Blake > --- > block/gluster.c | 54 +++++++++++++++++++++++++++----------------------= ----- > 1 file changed, 27 insertions(+), 27 deletions(-) R-b still stands on this one. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HhiXXVR9VDlWHi43wuKbdquQfDqFHtx51 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWRPZxAAoJEKeha0olJ0NqIVUH/3WoCalORAAj+D4Gf1c5XTSi yYDty70AitqLjl0VOb5YS2g5tGKoI65XlYURy20ex77APFOWvNaeiV4TuqNy0zlm l2rFtftYSehF3oLsJCOtl+si3aBPVdZZW8BNpFsNneRbRoFhjZi20YQOdocWX55B 4FPwhchjUFJtcCgZWlDA96lk5Y8E40cLoQ6+ldknOah7Yj+cdOfRLfeZgiVQroJz MtXOc5ndstAEqW7nUvxH5uFJMgoCh35hPgRPCJ7hjTKPe7uz5py0kt8TR7cvhee7 JC23POs2gI+Uslytptln69v6rKYD7iY3UHZJT3qObXwhSFMpfLLZOeslAOha04w= =7QfU -----END PGP SIGNATURE----- --HhiXXVR9VDlWHi43wuKbdquQfDqFHtx51--