From: Eric Blake <eblake@redhat.com>
To: Bandan Das <bsd@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu
Date: Thu, 12 Nov 2015 16:00:29 -0700 [thread overview]
Message-ID: <56451A0D.8@redhat.com> (raw)
In-Reply-To: <1447368949-15312-3-git-send-email-bsd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On 11/12/2015 03:55 PM, Bandan Das wrote:
> There's no indication of any sort that i440fx doesn't support
> "iommu=on""
>
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
> hw/pci-host/piix.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp)
> static void i440fx_realize(PCIDevice *dev, Error **errp)
> {
> dev->config[I440FX_SMRAM] = 0x02;
> +
> + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
> + error_report("warning: i440fx doesn't support emulated iommu\n");
No trailing \n with error_report().
With that fixed (and perhaps maintainer can do it),
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-12 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 22:55 [Qemu-devel] [PATCH v2 0/2] Minor cleanups when parsing the "iommu" option Bandan Das
2015-11-12 22:55 ` [Qemu-devel] [PATCH v2 1/2] q35: Check propery to determine if iommu is set Bandan Das
2015-11-12 22:55 ` [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu Bandan Das
2015-11-12 23:00 ` Eric Blake [this message]
2015-11-13 6:57 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56451A0D.8@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=bsd@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).