From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx0r5-000088-2O for qemu-devel@nongnu.org; Thu, 12 Nov 2015 18:00:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx0r1-0000lA-3I for qemu-devel@nongnu.org; Thu, 12 Nov 2015 18:00:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx0r0-0000ky-TR for qemu-devel@nongnu.org; Thu, 12 Nov 2015 18:00:31 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 676D08F4F1 for ; Thu, 12 Nov 2015 23:00:30 +0000 (UTC) References: <1447368949-15312-1-git-send-email-bsd@redhat.com> <1447368949-15312-3-git-send-email-bsd@redhat.com> From: Eric Blake Message-ID: <56451A0D.8@redhat.com> Date: Thu, 12 Nov 2015 16:00:29 -0700 MIME-Version: 1.0 In-Reply-To: <1447368949-15312-3-git-send-email-bsd@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3X3eU6pXAOU7CxeA9PNqtdche2BxRIail" Subject: Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das , qemu-devel@nongnu.org Cc: armbru@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3X3eU6pXAOU7CxeA9PNqtdche2BxRIail Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/12/2015 03:55 PM, Bandan Das wrote: > There's no indication of any sort that i440fx doesn't support > "iommu=3Don"" >=20 > Signed-off-by: Bandan Das > --- > hw/pci-host/piix.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *de= v, Error **errp) > static void i440fx_realize(PCIDevice *dev, Error **errp) > { > dev->config[I440FX_SMRAM] =3D 0x02; > + > + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {= > + error_report("warning: i440fx doesn't support emulated iommu\n= "); No trailing \n with error_report(). With that fixed (and perhaps maintainer can do it), Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3X3eU6pXAOU7CxeA9PNqtdche2BxRIail Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWRRoNAAoJEKeha0olJ0NqlGIH/ja3z3yd9aOs56482kP0WrVB zKjZDtoE1fCBIDkRLMdxt07+JZp4m14lF8+AdiHbAMtZqZSaAEPOOTiuMvRGcc55 YxBNcoT1Sp7wJuufRU86025icMI/4b9jjj4JXqYVyQczNHbfM6AQ3meMHh/ILOZD 7KTfMGT9vczxJ5GcMSOvU1MXf3B4C52VbWxciJJMBJPXG9GG+vX7nxdL4pBCSYa8 zt909bNJVTSH4dBcKTQdIbp78hLaJAmtjFF+DD7Mp3RemKHjN0A2iA9zRlYrj6g8 mOufMGMiE95woUWvex4B8ygJKKwQSSqfyFth9KA2eAa7tv9mutVhfKknRV28OWE= =ElQG -----END PGP SIGNATURE----- --3X3eU6pXAOU7CxeA9PNqtdche2BxRIail--