From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxB2T-00039o-J7 for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:53:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxB2O-0004Pt-Jj for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:53:01 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:36388 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxB2O-0004Pf-Ao for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:52:56 -0500 Message-ID: <5645B2F1.4020404@kamp.de> Date: Fri, 13 Nov 2015 10:52:49 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1447052973-14513-1-git-send-email-pl@kamp.de> <20151113094509.GD6650@stefanha-x1.localdomain> In-Reply-To: <20151113094509.GD6650@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: >> recent libnfs versions support logging debug messages. Add >> support for it in qemu through an URL parameter. >> >> Example: >> qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2 >> >> Signed-off-by: Peter Lieven >> --- >> v4->v5: add a comment in the code why we limit the debug level [Stefan] >> v3->v4: revert to the initial version, but limit max debug level >> v2->v3: use a per-drive option instead of a global one. [Stefan] >> v1->v2: reworked patch to accept the debug level as a cmdline >> parameter instead of an URI parameter [Stefan] >> >> block/nfs.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > Hi Peter, > Please use my official maintainer email address > when CCing me. I didn't spot the mail to GMail until after the QEMU 2.5 > hard freeze deadline. Okay. I think I used that email because you replayed to earlier versions of this Patch from your Gmail address. > > Only bug fixes are being merged for QEMU 2.5 now. I'm sorry that this > patch didn't make it. My block-next branch will be opening on Monday > and I'll merge this patch there for QEMU 2.6. Thats not critical in this case. I think same applies for the ATAPI stuff we worked on? There you used also your GMail account. Or can this be treated as a bugfix? Peter