From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Hollis Blanchard <hollis_blanchard@mentor.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address
Date: Fri, 13 Nov 2015 15:08:24 +0100 [thread overview]
Message-ID: <5645EED8.8000000@redhat.com> (raw)
In-Reply-To: <20151113102313.GG6650@stefanha-x1.localdomain>
On 13/11/2015 11:23, Stefan Hajnoczi wrote:
>> > tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr);
>> > - trace_memory_region_ops_read(mr, addr, tmp, size);
>> > + trace_memory_region_ops_read(mr->name, addr, tmp, size);
> mr->name may be NULL. There is a memory_region_name() function that
> always produces a real string. Perhaps it's best to use it.
It's also useful to have mr in the trace, for use within a debugger.
Paolo
next prev parent reply other threads:[~2015-11-13 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 1:09 [Qemu-devel] [PATCH 1/2] docs: "simple" trace backend does support strings Hollis Blanchard
2015-11-12 1:09 ` [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address Hollis Blanchard
2015-11-13 10:23 ` Stefan Hajnoczi
2015-11-13 14:08 ` Paolo Bonzini [this message]
2015-11-18 0:37 ` Hollis Blanchard
2015-11-25 7:20 ` Stefan Hajnoczi
2015-12-09 20:54 ` [Qemu-devel] subpage_write() and duplicated memory_region_ops_write tracepoints Hollis Blanchard
2015-12-09 21:12 ` Paolo Bonzini
2015-12-10 0:39 ` Hollis Blanchard
2015-12-10 9:27 ` Paolo Bonzini
2015-12-10 1:01 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645EED8.8000000@redhat.com \
--to=pbonzini@redhat.com \
--cc=hollis_blanchard@mentor.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).