From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxF1l-00018o-JM for qemu-devel@nongnu.org; Fri, 13 Nov 2015 09:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxF1g-0006hW-JB for qemu-devel@nongnu.org; Fri, 13 Nov 2015 09:08:33 -0500 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:38786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxF1g-0006hF-Ci for qemu-devel@nongnu.org; Fri, 13 Nov 2015 09:08:28 -0500 Received: by wmec201 with SMTP id c201so32160522wme.1 for ; Fri, 13 Nov 2015 06:08:27 -0800 (PST) Sender: Paolo Bonzini References: <1447290598-13069-1-git-send-email-hollis_blanchard@mentor.com> <1447290598-13069-2-git-send-email-hollis_blanchard@mentor.com> <20151113102313.GG6650@stefanha-x1.localdomain> From: Paolo Bonzini Message-ID: <5645EED8.8000000@redhat.com> Date: Fri, 13 Nov 2015 15:08:24 +0100 MIME-Version: 1.0 In-Reply-To: <20151113102313.GG6650@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Hollis Blanchard Cc: qemu-devel@nongnu.org On 13/11/2015 11:23, Stefan Hajnoczi wrote: >> > tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr); >> > - trace_memory_region_ops_read(mr, addr, tmp, size); >> > + trace_memory_region_ops_read(mr->name, addr, tmp, size); > mr->name may be NULL. There is a memory_region_name() function that > always produces a real string. Perhaps it's best to use it. It's also useful to have mr in the trace, for use within a debugger. Paolo