From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxHTH-0006PZ-94 for qemu-devel@nongnu.org; Fri, 13 Nov 2015 11:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxHTD-0005sn-14 for qemu-devel@nongnu.org; Fri, 13 Nov 2015 11:45:07 -0500 References: <1447419494-10670-1-git-send-email-pbonzini@redhat.com> From: Thomas Huth Message-ID: <5646138B.7000809@redhat.com> Date: Fri, 13 Nov 2015 17:44:59 +0100 MIME-Version: 1.0 In-Reply-To: <1447419494-10670-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: convert qemu_log to error_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 13/11/15 13:58, Paolo Bonzini wrote: > Ensure that the error is printed with the proper timestamp. > > Signed-off-by: Paolo Bonzini > --- > net/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/dump.c b/net/dump.c > index dd0555f..ab71ffc 100644 > --- a/net/dump.c > +++ b/net/dump.c > @@ -84,7 +84,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct iovec *iov, int cnt) > cnt = iov_copy(&dumpiov[1], cnt, iov, cnt, 0, caplen); > > if (writev(s->fd, dumpiov, cnt + 1) != sizeof(hdr) + caplen) { > - qemu_log("-net dump write error - stop dump\n"); > + error_report("-net dump write error - stop dump"); > close(s->fd); > s->fd = -1; > } We should maybe also reword that text a little bit, since this code is now used by the netdev dumping filter, too, so "-net dump" is not the only user anymore. Anyway, that can also be done with a later patch, so if you don't want to do this now: Reviewed-by: Thomas Huth