From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Christian Borntraeger" <borntraeger@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Pavel Fedin <p.fedin@samsung.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable
Date: Mon, 16 Nov 2015 09:53:06 +0100 [thread overview]
Message-ID: <56499972.1080103@redhat.com> (raw)
In-Reply-To: <56465533.3030501@suse.de>
On 13/11/2015 22:25, Andreas Färber wrote:
> Thanks! sclp_init() seems to violate several QOM design principles in
> that it uses object_new() during TypeInfo::instance_init()
There's nothing wrong with that. It's wrong however to use
qdev_set_parent_bus in instance_init. That should be moved to
sclp_realize, before the realized property is set to true.
Otherwise, sclp->event_facility outlives its parent. I'm not sure why
that works only with the list and not with the hash table though. It
may well be a bug in this patch.
> and uses a TYPE_... constant as property name.
That's just a little weird, it doesn't break anything per se.
Paolo
next prev parent reply other threads:[~2015-11-16 8:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 12:37 [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling Daniel P. Berrange
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 1/7] qom: introduce ObjectPropertyIterator struct for iteration Daniel P. Berrange
2015-11-05 16:59 ` Andreas Färber
2015-11-17 15:25 ` Markus Armbruster
2015-11-17 15:27 ` Daniel P. Berrange
2015-11-17 15:35 ` Markus Armbruster
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 2/7] qmp: convert QMP code to use object property iterators Daniel P. Berrange
2015-11-05 17:08 ` Andreas Färber
2015-11-17 15:26 ` Markus Armbruster
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 3/7] vl: convert machine help " Daniel P. Berrange
2015-11-05 17:10 ` Andreas Färber
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 4/7] ppc: convert spapr " Daniel P. Berrange
2015-11-05 17:16 ` Andreas Färber
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 5/7] net: convert net filter " Daniel P. Berrange
2015-11-05 17:18 ` Andreas Färber
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable Daniel P. Berrange
2015-11-05 18:05 ` Andreas Färber
2015-11-06 9:02 ` Pavel Fedin
2015-11-06 9:31 ` Daniel P. Berrange
2015-11-06 9:37 ` Pavel Fedin
2015-11-13 18:14 ` Andreas Färber
2015-11-13 21:00 ` Christian Borntraeger
2015-11-13 21:25 ` Andreas Färber
2015-11-16 7:13 ` Pavel Fedin
2015-11-16 8:16 ` Christian Borntraeger
2015-11-16 9:38 ` Andreas Färber
2015-11-16 10:31 ` Pavel Fedin
2015-11-16 16:44 ` Andreas Färber
2015-11-16 16:53 ` Daniel P. Berrange
2015-11-16 8:53 ` Paolo Bonzini [this message]
2015-11-16 9:48 ` Andreas Färber
2015-11-16 9:50 ` Paolo Bonzini
2015-11-16 11:35 ` Daniel P. Berrange
2015-10-13 12:37 ` [Qemu-devel] [PATCH v4 7/7] qom: allow properties to be registered against classes Daniel P. Berrange
2015-10-13 13:18 ` Pavel Fedin
2015-11-05 18:12 ` Andreas Färber
2015-11-06 9:32 ` Daniel P. Berrange
2015-11-18 23:35 ` Andreas Färber
2015-10-13 12:54 ` [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling Andreas Färber
2015-10-13 12:59 ` Daniel P. Berrange
2015-10-14 6:57 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56499972.1080103@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).