From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyFXF-000590-Uo for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyFXC-00047X-Ow for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:53:13 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:37268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyFXC-00047G-Ib for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:53:10 -0500 Received: by wmww144 with SMTP id w144so108693722wmw.0 for ; Mon, 16 Nov 2015 00:53:09 -0800 (PST) Sender: Paolo Bonzini References: <1444739866-14798-1-git-send-email-berrange@redhat.com> <1444739866-14798-7-git-send-email-berrange@redhat.com> <5646286B.2030307@suse.de> <56464F8A.3070709@de.ibm.com> <56465533.3030501@suse.de> From: Paolo Bonzini Message-ID: <56499972.1080103@redhat.com> Date: Mon, 16 Nov 2015 09:53:06 +0100 MIME-Version: 1.0 In-Reply-To: <56465533.3030501@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , Christian Borntraeger Cc: Peter Maydell , Pavel Fedin , qemu-devel@nongnu.org, Markus Armbruster On 13/11/2015 22:25, Andreas Färber wrote: > Thanks! sclp_init() seems to violate several QOM design principles in > that it uses object_new() during TypeInfo::instance_init() There's nothing wrong with that. It's wrong however to use qdev_set_parent_bus in instance_init. That should be moved to sclp_realize, before the realized property is set to true. Otherwise, sclp->event_facility outlives its parent. I'm not sure why that works only with the list and not with the hash table though. It may well be a bug in this patch. > and uses a TYPE_... constant as property name. That's just a little weird, it doesn't break anything per se. Paolo