From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyGR2-0000yy-Vw for qemu-devel@nongnu.org; Mon, 16 Nov 2015 04:50:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyGQz-0001M0-PC for qemu-devel@nongnu.org; Mon, 16 Nov 2015 04:50:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyGQz-0001Lw-K2 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 04:50:49 -0500 References: <1444739866-14798-1-git-send-email-berrange@redhat.com> <1444739866-14798-7-git-send-email-berrange@redhat.com> <5646286B.2030307@suse.de> <56464F8A.3070709@de.ibm.com> <56465533.3030501@suse.de> <56499972.1080103@redhat.com> <5649A672.5040605@suse.de> From: Paolo Bonzini Message-ID: <5649A6F4.6040007@redhat.com> Date: Mon, 16 Nov 2015 10:50:44 +0100 MIME-Version: 1.0 In-Reply-To: <5649A672.5040605@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= Cc: Christian Borntraeger , Pavel Fedin , qemu-devel@nongnu.org, Markus Armbruster , Peter Maydell On 16/11/2015 10:48, Andreas F=E4rber wrote: > > > Thanks! sclp_init() seems to violate several QOM design principles = in > > > that it uses object_new() during TypeInfo::instance_init() > >=20 > > There's nothing wrong with that. It's wrong however to use > > qdev_set_parent_bus in instance_init. That should be moved to > > sclp_realize, before the realized property is set to true. >=20 > Negative, realize is too late. Since there are two call sites for > initialization, I don't see a better place for it. Why is realize too late to set the parent bus? Paolo