From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZyJOa-0006jF-7r
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 08:00:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZyJOU-0000zK-9o
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 08:00:32 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:58914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZyJOT-0000xq-6n
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 08:00:26 -0500
References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1446551816-15768-6-git-send-email-zhang.zhanghailiang@huawei.com>
	<564612DB.2060906@redhat.com>
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-ID: <5649D356.5060202@huawei.com>
Date: Mon, 16 Nov 2015 21:00:06 +0800
MIME-Version: 1.0
In-Reply-To: <564612DB.2060906@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 05/38] migration: Integrate
 COLO checkpoint process into migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com

On 2015/11/14 0:42, Eric Blake wrote:
> On 11/03/2015 04:56 AM, zhanghailiang wrote:
>> Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state
>> after the first live migration successfully finished.
>>
>> We reuse migration thread, so if colo is enabled by user, migration thread will
>> go into the process of colo.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> v10: Simplify process by dropping colo thread and reusing migration thread.
>>       (Dave's suggestion)
>> ---
>
>> +++ b/qapi-schema.json
>> @@ -439,7 +439,7 @@
>>   ##
>>   { 'enum': 'MigrationStatus',
>>     'data': [ 'none', 'setup', 'cancelling', 'cancelled',
>> -            'active', 'completed', 'failed' ] }
>> +            'active', 'completed', 'failed', 'colo' ] }
>>
>
> Missing documentation of the new state, including a '(since 2.6)' tag.
>

Good catch, i will fix it in next version, thanks.