From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot
Date: Mon, 16 Nov 2015 21:23:58 +0100 [thread overview]
Message-ID: <564A3B5E.1080400@redhat.com> (raw)
In-Reply-To: <1447419624-21918-1-git-send-email-berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On 13.11.2015 14:00, Alberto Garcia wrote:
> Otherwise the AioContext will never be released.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> blockdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index fc85128..4dcc510 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
> .prepare = external_snapshot_prepare,
> .commit = external_snapshot_commit,
> .abort = external_snapshot_abort,
> + .clean = external_snapshot_clean,
> },
> [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
> .instance_size = sizeof(ExternalSnapshotState),
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-11-16 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 13:00 [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot Alberto Garcia
2015-11-16 6:09 ` Fam Zheng
2015-11-16 20:23 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A3B5E.1080400@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).