From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyQJt-0004Pk-HC for qemu-devel@nongnu.org; Mon, 16 Nov 2015 15:24:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyQJs-0000UQ-Ls for qemu-devel@nongnu.org; Mon, 16 Nov 2015 15:24:09 -0500 References: <1447419624-21918-1-git-send-email-berto@igalia.com> From: Max Reitz Message-ID: <564A3B5E.1080400@redhat.com> Date: Mon, 16 Nov 2015 21:23:58 +0100 MIME-Version: 1.0 In-Reply-To: <1447419624-21918-1-git-send-email-berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Rc7AEVeVgj6DF0io4pO0I4gT98cb748A" Subject: Re: [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Rc7AEVeVgj6DF0io4pO0I4gT98cb748A Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 13.11.2015 14:00, Alberto Garcia wrote: > Otherwise the AioContext will never be released. >=20 > Signed-off-by: Alberto Garcia > --- > blockdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/blockdev.c b/blockdev.c > index fc85128..4dcc510 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] =3D { > .prepare =3D external_snapshot_prepare, > .commit =3D external_snapshot_commit, > .abort =3D external_snapshot_abort, > + .clean =3D external_snapshot_clean, > }, > [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] =3D { > .instance_size =3D sizeof(ExternalSnapshotState), Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block Max --2Rc7AEVeVgj6DF0io4pO0I4gT98cb748A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWSjteAAoJEDuxQgLoOKyt4xkH/AulAJ04cSahs3ie9mEDKmo+ Yf0UUt1HYGLgT8txSfVlXaK6qmvrPEgUEJi5gMYbAkBAmdtaZjEc5z9b5LangVYj oPTizxPeYVJ3vXfKgQX2U33kO1x3dUKBBvzCLW8zqMDEa3ycHLTOjd7efnbAYHbJ 4MHkUZ1pB1hVaGrgkXkkSsEdh4Awg+WeKOKsDfWKDK+HeOMfH2B99HN6HP/AEH+w +Z0FRpkRAT/M9kMZ9Jg+3wkikKLKp4tXLyW/FSoUymop58bvz5al/qJz1iq53kir i7+D+4smVVwb1msA1ORjIGhVL2+9N2wE3gbg+fP2tLAHF7VQEQLOQVRQLzMUxH4= =G7w5 -----END PGP SIGNATURE----- --2Rc7AEVeVgj6DF0io4pO0I4gT98cb748A--