From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyS1h-0007zi-4h for qemu-devel@nongnu.org; Mon, 16 Nov 2015 17:13:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyS1g-000719-51 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 17:13:29 -0500 References: <1446618049-13596-22-git-send-email-eblake@redhat.com> <1446737402-15597-1-git-send-email-armbru@redhat.com> <1446737402-15597-4-git-send-email-armbru@redhat.com> <20151105160114.GG15525@redhat.com> <563B86CD.4090203@redhat.com> <87a8qrculz.fsf@blackfin.pond.sub.org> <87mvur5jyy.fsf@blackfin.pond.sub.org> <87r3jxudkx.fsf_-_@blackfin.pond.sub.org> From: Eric Blake Message-ID: <564A54FC.2070001@redhat.com> Date: Mon, 16 Nov 2015 15:13:16 -0700 MIME-Version: 1.0 In-Reply-To: <87r3jxudkx.fsf_-_@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e3bC0HUEEc9NVI4B8J510b1HqH4NntdND" Subject: [Qemu-devel] blkdebug event names [was: What to do about QAPI naming convention violations] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, qemu block , mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e3bC0HUEEc9NVI4B8J510b1HqH4NntdND Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2015 07:35 AM, Markus Armbruster wrote: >>> Oddballs not related to case: >>> >>> * enum BlkdebugEvent uses '.' in member names > I had a closer look at how the screwy names are used in QMP to see how > much of the mess is fixable within reason. >=20 > BlkdebugEvent is related to the external blkdebug interface described b= y > docs/blkdebug.txt. The two are actually decoupled, i.e. changing the > QAPI names doesn't affect the external debugging interface, and vice > versa. Making them different can only cause confusion, though. Not > sure we can fix the names. I think that having block/blkdebug.c:event_name[] duplicate qapi BlkdebugEvent is a mistake, and that we are better off unifying them. The other question is whether backwards compatibility is important here, or if we can just break the naming conventions to something sane. That is, if the primary user of blkdebug is our testsuite, and we fix our testsuite to match the new names, will we be breaking external users? Libvirt certainly doesn't expose blkdebug, and I doubt any other external wrapper will be that upset if we force better names here. >=20 > BlkdebugSetStateOptions and BlockdevDriver are input for blockdev-add. > Fixable. May not even need backward compatibility. Yep, I concur that blockdev-add is not stable yet, and that there are no other QMP uses of BlkdebugEvent, so unless anyone else complains, I think we can make the change to conventional spelling. At this point, I think 2.5 is too late, so the change will have to go into 2.6, but I'm preparing a patch for fixing this interface. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --e3bC0HUEEc9NVI4B8J510b1HqH4NntdND Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWSlUBAAoJEKeha0olJ0NqkuEH/11T5zDEJBNIzu+zNupshSgP 5JEimNHFjaEJuyHAJuBTjgEYxsx68qTyYowQ2uPyL8UquF4Mdy/XBgDoTbe7WpmR DYutP1IeU/vdDj0kV4To6023/jnxFYECSwhxcjeXNI58he94dk6YQ3KAXPrvn3ce VKMa6PgX5+w49MZkQ2saFqd9Z3Mj37lNndXaqTeXHMyJngDNEgq5/WLFf7k0dfmr 5rtFZeeSGaRRKmXQN3GQiOE7cDvdnIeKjCvdYM1zRXPxPjL4q6KBQUfJ53L5x3zl E6UYFvoKn7BpBnScPzyjpWGqLMty20B5jm56CNE1LOSzOAvtk7HtUU6ydwKqIjI= =BCnu -----END PGP SIGNATURE----- --e3bC0HUEEc9NVI4B8J510b1HqH4NntdND--