Re: [Qemu-devel] [PATCH v2 4/5] sockets: remove use of QemuOpts from socket_dgram

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

On 11/17/2015 10:00 AM, Daniel P. Berrange wrote:
> The socket_dgram method accepts a QAPI SocketAddress object
> which it then turns into QemuOpts before calling the
> inet_dgram_opts helper method. By converting the latter to
> use QAPI SocketAddress directly, the QemuOpts conversion
> step can be eliminated.
> 
> This also fixes the problem where ipv4=off && ipv6=off
> would be treated the same as ipv4=on && ipv6=on
> 
> This removes the very last use of QemuOpts from the
> sockets code, so the socket_optslist[] array is also
> removed.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  include/qemu/sockets.h |  1 -
>  util/qemu-sockets.c    | 99 ++++++++++++--------------------------------------
>  2 files changed, 24 insertions(+), 76 deletions(-)
> 

I might have split the cleanup into a separate patch, but can understand
if the compiler was warning about unused static items.  Similar
questions about the accuracy of the commit message as in the earlier
patches, but the code cleanup looked sane to me.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]