From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyqKF-0006Tm-RV for qemu-devel@nongnu.org; Tue, 17 Nov 2015 19:10:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyqKC-00087i-MP for qemu-devel@nongnu.org; Tue, 17 Nov 2015 19:10:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyqKC-00087d-Fq for qemu-devel@nongnu.org; Tue, 17 Nov 2015 19:10:12 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id D9BEA19F274 for ; Wed, 18 Nov 2015 00:10:11 +0000 (UTC) References: <1447779624-21625-1-git-send-email-berrange@redhat.com> <1447779624-21625-5-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <564BC1DD.1070701@redhat.com> Date: Tue, 17 Nov 2015 17:10:05 -0700 MIME-Version: 1.0 In-Reply-To: <1447779624-21625-5-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qLQWDtRoCn05DnWckV8d48Eeu6gFTE0gq" Subject: Re: [Qemu-devel] [PATCH v2 4/5] sockets: remove use of QemuOpts from socket_dgram List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qLQWDtRoCn05DnWckV8d48Eeu6gFTE0gq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The socket_dgram method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_dgram_opts helper method. By converting the latter to > use QAPI SocketAddress directly, the QemuOpts conversion > step can be eliminated. >=20 > This also fixes the problem where ipv4=3Doff && ipv6=3Doff > would be treated the same as ipv4=3Don && ipv6=3Don >=20 > This removes the very last use of QemuOpts from the > sockets code, so the socket_optslist[] array is also > removed. >=20 > Signed-off-by: Daniel P. Berrange > --- > include/qemu/sockets.h | 1 - > util/qemu-sockets.c | 99 ++++++++++++------------------------------= -------- > 2 files changed, 24 insertions(+), 76 deletions(-) >=20 I might have split the cleanup into a separate patch, but can understand if the compiler was warning about unused static items. Similar questions about the accuracy of the commit message as in the earlier patches, but the code cleanup looked sane to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qLQWDtRoCn05DnWckV8d48Eeu6gFTE0gq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWS8HdAAoJEKeha0olJ0NqXVQIAIoTuIvGlp9+MKLH9K2E+9qo A02qZbQJneEigs+fLxP/ZzO/rPdZUG90vcynwFfca6W9BHxIy/s39ihoK6EcONJf 3gzwwdKn3HFyiW5q1S8L4Mc0ybxHy2EIXas5JJUXCQc9qO1mOB5/zp2H/SRSnz6T K+UsXIk3gJJCuJ4pIOTXFwiHiHelDPA/aa/tpB12noIjET7+ediVv95H9sVeWEh0 EXJGJc6PX7Xq95UOn4nlrRlKAvbC80dxcE3lQpSkoRfSR0US2r8SNCMQjUWvnWoU SthyoJ2/jdh07WEa6+JDsTDheQy9C6d4MqWTYgUmIqKu/GYjG8sGAhpLBGKYao4= =ypzj -----END PGP SIGNATURE----- --qLQWDtRoCn05DnWckV8d48Eeu6gFTE0gq--