From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyqMH-0007QC-Vn for qemu-devel@nongnu.org; Tue, 17 Nov 2015 19:12:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyqME-0008J1-Ov for qemu-devel@nongnu.org; Tue, 17 Nov 2015 19:12:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyqME-0008Ix-J4 for qemu-devel@nongnu.org; Tue, 17 Nov 2015 19:12:18 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 2E426C0BB288 for ; Wed, 18 Nov 2015 00:12:18 +0000 (UTC) References: <1447779624-21625-1-git-send-email-berrange@redhat.com> <1447779624-21625-6-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <564BC261.5030205@redhat.com> Date: Tue, 17 Nov 2015 17:12:17 -0700 MIME-Version: 1.0 In-Reply-To: <1447779624-21625-6-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UmISRLISoF1GwkKNU5uIh7QRRPwwN4nc4" Subject: Re: [Qemu-devel] [PATCH v2 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UmISRLISoF1GwkKNU5uIh7QRRPwwN4nc4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The VNC code for interpreting QemuOpts does not currently > distinguish between ipv4/ipv6 being omitted, and being > set to 'off', because historically the 'ipv4' and 'ipv6' > options were just flags which did not accept a value. >=20 > The upshot is that if someone runs >=20 > $QEMU -vnc localhost:1,ipv6=3Doff >=20 > QEMU still uses PF_UNSPEC and thus may still bind to IPv6, > when it should use PF_INET. >=20 > This is another instance of the problem previously fixed > for chardevs in >=20 > commit b77e7c8e99f9ac726c4eaa2fc3461fd886017dc0 > Author: Paolo Bonzini > Date: Mon Oct 12 15:35:16 2015 +0200 >=20 > qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts >=20 > Signed-off-by: Daniel P. Berrange > --- > ui/vnc.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UmISRLISoF1GwkKNU5uIh7QRRPwwN4nc4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWS8JhAAoJEKeha0olJ0NqFrcH/2FGYe6KaAYngX0hx2cYfkYO Bx1EKpxt3r4yfh7HYbbFd3N6ZzuXnchpV3lXcmONVu4qd5NdnmMLNJFmOC2vrwCs ESUjPNje5ljFgZSiqGVudTOyRQP3SG8Cq0aagrgUFoRMZCfXh1c0diRaDly4HIkv mqQruPCkQIav11VbY271/J7YoOl+pAXjlvrxJjL4X1EfVU+xABaHc66gf7RKZDKi MB0ohOMUi0DwBdkQGO6E/D2bd4sa3XAnxwSYcd8ihygLUoLEsFUwcAC+nXjIs6lO AsLu7hj/NXj5j/lRvR8ZtE34jFZ5h9RVm4eScTFJhOy8rjGfqhcqB17qoPUrIBw= =DISQ -----END PGP SIGNATURE----- --UmISRLISoF1GwkKNU5uIh7QRRPwwN4nc4--