From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZysB0-0004Oc-Qe for qemu-devel@nongnu.org; Tue, 17 Nov 2015 21:08:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZysAw-0008Dv-Q2 for qemu-devel@nongnu.org; Tue, 17 Nov 2015 21:08:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZysAw-0008Df-Kb for qemu-devel@nongnu.org; Tue, 17 Nov 2015 21:08:46 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 3DB2A42E5DB for ; Wed, 18 Nov 2015 02:08:46 +0000 (UTC) References: <1447772226-28517-1-git-send-email-mst@redhat.com> From: Jason Wang Message-ID: <564BDDA8.3030505@redhat.com> Date: Wed, 18 Nov 2015 10:08:40 +0800 MIME-Version: 1.0 In-Reply-To: <1447772226-28517-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Victor Kaplansky On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote: > Some feratures (such as ctrl vq) are supported > by qemu without need to communicate with the > backend. > > Drop them from the feature mask so we set them > unconditionally. > > Reported-by: Victor Kaplansky > Signed-off-by: Michael S. Tsirkin > --- > hw/net/vhost_net.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index 14337a4..8c9b52d 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -77,15 +77,6 @@ static const int user_feature_bits[] = { > VIRTIO_NET_F_HOST_ECN, > VIRTIO_NET_F_HOST_UFO, > VIRTIO_NET_F_MRG_RXBUF, > - VIRTIO_NET_F_STATUS, > - VIRTIO_NET_F_CTRL_VQ, > - VIRTIO_NET_F_CTRL_RX, > - VIRTIO_NET_F_CTRL_VLAN, > - VIRTIO_NET_F_CTRL_RX_EXTRA, > - VIRTIO_NET_F_CTRL_MAC_ADDR, > - VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, > - > - VIRTIO_NET_F_GUEST_ANNOUNCE, > > VIRTIO_NET_F_MQ, > Acked-by: Jason Wang