qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Victor Kaplansky <vkaplans@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features
Date: Wed, 18 Nov 2015 10:11:42 +0800	[thread overview]
Message-ID: <564BDE5E.8090100@redhat.com> (raw)
In-Reply-To: <564BDDA8.3030505@redhat.com>



On 11/18/2015 10:08 AM, Jason Wang wrote:
>
> On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote:
>> Some feratures (such as ctrl vq) are supported
>> by qemu without need to communicate with the
>> backend.
>>
>> Drop them from the feature mask so we set them
>> unconditionally.
>>
>> Reported-by: Victor Kaplansky <vkaplans@redhat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>  hw/net/vhost_net.c | 9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
>> index 14337a4..8c9b52d 100644
>> --- a/hw/net/vhost_net.c
>> +++ b/hw/net/vhost_net.c
>> @@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
>>      VIRTIO_NET_F_HOST_ECN,
>>      VIRTIO_NET_F_HOST_UFO,
>>      VIRTIO_NET_F_MRG_RXBUF,
>> -    VIRTIO_NET_F_STATUS,
>> -    VIRTIO_NET_F_CTRL_VQ,
>> -    VIRTIO_NET_F_CTRL_RX,
>> -    VIRTIO_NET_F_CTRL_VLAN,
>> -    VIRTIO_NET_F_CTRL_RX_EXTRA,
>> -    VIRTIO_NET_F_CTRL_MAC_ADDR,
>> -    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
>> -
>> -    VIRTIO_NET_F_GUEST_ANNOUNCE,
>>  
>>      VIRTIO_NET_F_MQ,
>>  
> Acked-by: Jason Wang <jasowang@redhat.com>

How about VIRTIO_NET_F_GUEST_* ?

      reply	other threads:[~2015-11-18  2:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17 14:57 [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features Michael S. Tsirkin
2015-11-18  2:08 ` Jason Wang
2015-11-18  2:11   ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564BDE5E.8090100@redhat.com \
    --to=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vkaplans@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).