From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZysE1-0005dX-1f
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 21:11:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZysDw-0000RW-TQ
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 21:11:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54420)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZysDw-0000RS-Nk
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 21:11:52 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 4367D8F4E0
	for <qemu-devel@nongnu.org>; Wed, 18 Nov 2015 02:11:52 +0000 (UTC)
References: <1447772226-28517-1-git-send-email-mst@redhat.com>
	<564BDDA8.3030505@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <564BDE5E.8090100@redhat.com>
Date: Wed, 18 Nov 2015 10:11:42 +0800
MIME-Version: 1.0
In-Reply-To: <564BDDA8.3030505@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Victor Kaplansky <vkaplans@redhat.com>



On 11/18/2015 10:08 AM, Jason Wang wrote:
>
> On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote:
>> Some feratures (such as ctrl vq) are supported
>> by qemu without need to communicate with the
>> backend.
>>
>> Drop them from the feature mask so we set them
>> unconditionally.
>>
>> Reported-by: Victor Kaplansky <vkaplans@redhat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>  hw/net/vhost_net.c | 9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
>> index 14337a4..8c9b52d 100644
>> --- a/hw/net/vhost_net.c
>> +++ b/hw/net/vhost_net.c
>> @@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
>>      VIRTIO_NET_F_HOST_ECN,
>>      VIRTIO_NET_F_HOST_UFO,
>>      VIRTIO_NET_F_MRG_RXBUF,
>> -    VIRTIO_NET_F_STATUS,
>> -    VIRTIO_NET_F_CTRL_VQ,
>> -    VIRTIO_NET_F_CTRL_RX,
>> -    VIRTIO_NET_F_CTRL_VLAN,
>> -    VIRTIO_NET_F_CTRL_RX_EXTRA,
>> -    VIRTIO_NET_F_CTRL_MAC_ADDR,
>> -    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
>> -
>> -    VIRTIO_NET_F_GUEST_ANNOUNCE,
>>  
>>      VIRTIO_NET_F_MQ,
>>  
> Acked-by: Jason Wang <jasowang@redhat.com>

How about VIRTIO_NET_F_GUEST_* ?