* [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features
@ 2015-11-17 14:57 Michael S. Tsirkin
2015-11-18 2:08 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2015-11-17 14:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Victor Kaplansky, Jason Wang
Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.
Drop them from the feature mask so we set them
unconditionally.
Reported-by: Victor Kaplansky <vkaplans@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/vhost_net.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 14337a4..8c9b52d 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
VIRTIO_NET_F_HOST_ECN,
VIRTIO_NET_F_HOST_UFO,
VIRTIO_NET_F_MRG_RXBUF,
- VIRTIO_NET_F_STATUS,
- VIRTIO_NET_F_CTRL_VQ,
- VIRTIO_NET_F_CTRL_RX,
- VIRTIO_NET_F_CTRL_VLAN,
- VIRTIO_NET_F_CTRL_RX_EXTRA,
- VIRTIO_NET_F_CTRL_MAC_ADDR,
- VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
-
- VIRTIO_NET_F_GUEST_ANNOUNCE,
VIRTIO_NET_F_MQ,
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features
2015-11-17 14:57 [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features Michael S. Tsirkin
@ 2015-11-18 2:08 ` Jason Wang
2015-11-18 2:11 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jason Wang @ 2015-11-18 2:08 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Victor Kaplansky
On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote:
> Some feratures (such as ctrl vq) are supported
> by qemu without need to communicate with the
> backend.
>
> Drop them from the feature mask so we set them
> unconditionally.
>
> Reported-by: Victor Kaplansky <vkaplans@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/net/vhost_net.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 14337a4..8c9b52d 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
> VIRTIO_NET_F_HOST_ECN,
> VIRTIO_NET_F_HOST_UFO,
> VIRTIO_NET_F_MRG_RXBUF,
> - VIRTIO_NET_F_STATUS,
> - VIRTIO_NET_F_CTRL_VQ,
> - VIRTIO_NET_F_CTRL_RX,
> - VIRTIO_NET_F_CTRL_VLAN,
> - VIRTIO_NET_F_CTRL_RX_EXTRA,
> - VIRTIO_NET_F_CTRL_MAC_ADDR,
> - VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
> -
> - VIRTIO_NET_F_GUEST_ANNOUNCE,
>
> VIRTIO_NET_F_MQ,
>
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features
2015-11-18 2:08 ` Jason Wang
@ 2015-11-18 2:11 ` Jason Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jason Wang @ 2015-11-18 2:11 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Victor Kaplansky
On 11/18/2015 10:08 AM, Jason Wang wrote:
>
> On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote:
>> Some feratures (such as ctrl vq) are supported
>> by qemu without need to communicate with the
>> backend.
>>
>> Drop them from the feature mask so we set them
>> unconditionally.
>>
>> Reported-by: Victor Kaplansky <vkaplans@redhat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>> hw/net/vhost_net.c | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
>> index 14337a4..8c9b52d 100644
>> --- a/hw/net/vhost_net.c
>> +++ b/hw/net/vhost_net.c
>> @@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
>> VIRTIO_NET_F_HOST_ECN,
>> VIRTIO_NET_F_HOST_UFO,
>> VIRTIO_NET_F_MRG_RXBUF,
>> - VIRTIO_NET_F_STATUS,
>> - VIRTIO_NET_F_CTRL_VQ,
>> - VIRTIO_NET_F_CTRL_RX,
>> - VIRTIO_NET_F_CTRL_VLAN,
>> - VIRTIO_NET_F_CTRL_RX_EXTRA,
>> - VIRTIO_NET_F_CTRL_MAC_ADDR,
>> - VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
>> -
>> - VIRTIO_NET_F_GUEST_ANNOUNCE,
>>
>> VIRTIO_NET_F_MQ,
>>
> Acked-by: Jason Wang <jasowang@redhat.com>
How about VIRTIO_NET_F_GUEST_* ?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-18 2:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-17 14:57 [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features Michael S. Tsirkin
2015-11-18 2:08 ` Jason Wang
2015-11-18 2:11 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).