From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyxR8-0001uy-MP for qemu-devel@nongnu.org; Wed, 18 Nov 2015 02:45:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyxR3-0005xd-Ts for qemu-devel@nongnu.org; Wed, 18 Nov 2015 02:45:50 -0500 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:33167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyxR3-0005xD-NB for qemu-devel@nongnu.org; Wed, 18 Nov 2015 02:45:45 -0500 Received: by pabfh17 with SMTP id fh17so38059367pab.0 for ; Tue, 17 Nov 2015 23:45:44 -0800 (PST) References: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> <20151109084731.GH18558@voom.redhat.com> From: Alexey Kardashevskiy Message-ID: <564C2CA3.8000307@ozlabs.ru> Date: Wed, 18 Nov 2015 18:45:39 +1100 MIME-Version: 1.0 In-Reply-To: <20151109084731.GH18558@voom.redhat.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 11/09/2015 07:47 PM, David Gibson wrote: > On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: >> Section B.6.2.1 Root Node Properties of PAPR specification defines >> a set of properties which shall be present in the device tree root, >> one of these properties is "system-id" which "should be unique across >> all systems and all manufacturers". Since UUID is meant to be unique, >> it makes sense to use it as "system-id". >> >> This adds "system-id" property to the device tree root when not empty. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> This might be expected by AIX so here is the patch. >> I am really not sure if it makes sense to initialize property when >> UUID is all zeroes as the requirement is "unique" and zero-uuid is >> not. > > Yeah, I think it would be better to omit system-id entirely when a > UUID hasn't been supplied. so this did not go anywhere yet, did it? >> >> --- >> hw/ppc/spapr.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index de77528..e8b407d 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -374,6 +374,9 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base, >> qemu_uuid[14], qemu_uuid[15]); >> >> _FDT((fdt_property_string(fdt, "vm,uuid", buf))); >> + if (qemu_uuid_set) { >> + _FDT((fdt_property_string(fdt, "system-id", buf))); >> + } >> g_free(buf); >> >> if (qemu_get_vm_name()) { > -- Alexey