From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz1u0-0005Pb-Ts for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:32:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz1tx-00027M-43 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:31:56 -0500 Sender: Paolo Bonzini References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-45-git-send-email-benh@kernel.crashing.org> From: Paolo Bonzini Message-ID: <564C6FB3.1000703@redhat.com> Date: Wed, 18 Nov 2015 13:31:47 +0100 MIME-Version: 1.0 In-Reply-To: <1447201710-10229-45-git-send-email-benh@kernel.crashing.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 44/77] pci-bridge: Set a supported devfn_min for bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 11/11/2015 01:27, Benjamin Herrenschmidt wrote: > if (bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) { > + /* SHCP gets upset if we try to use slot 0 */ > + br->sec_bus.devfn_min = PCI_FUNC_MAX; > dev->config[PCI_INTERRUPT_PIN] = 0x1; > memory_region_init(&bridge_dev->bar, OBJECT(dev), "shpc-bar", > shpc_bar_size(dev)); This needs backwards compatibility gunk unfortunately. However we should fix it in 2.5 because it's a bug. I'll send a patch. Paolo