From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zz23f-0002An-Bl
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:41:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zz23c-0004jL-2H
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:41:55 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org>
	<1447201710-10229-45-git-send-email-benh@kernel.crashing.org>
	<564C6FB3.1000703@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <564C720B.10106@redhat.com>
Date: Wed, 18 Nov 2015 13:41:47 +0100
MIME-Version: 1.0
In-Reply-To: <564C6FB3.1000703@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 44/77] pci-bridge: Set a supported
 devfn_min for bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 18/11/2015 13:31, Paolo Bonzini wrote:
> 
> 
> On 11/11/2015 01:27, Benjamin Herrenschmidt wrote:
>>      if (bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) {
>> +        /* SHCP gets upset if we try to use slot 0 */
>> +        br->sec_bus.devfn_min = PCI_FUNC_MAX;
>>          dev->config[PCI_INTERRUPT_PIN] = 0x1;
>>          memory_region_init(&bridge_dev->bar, OBJECT(dev), "shpc-bar",
>>                             shpc_bar_size(dev));
> 
> This needs backwards compatibility gunk unfortunately.  However we
> should fix it in 2.5 because it's a bug.  I'll send a patch.

Actually it turns out that the forbidden configuration is blocked elsewhere:

$ x86_64-softmmu/qemu-system-x86_64 \
	-device pci-bridge,id=foo,chassis_nr=1 \
	-device virtio-scsi-pci,bus=foo
qemu-system-x86_64: -device virtio-scsi-pci,bus=foo: Unsupported PCI
slot 0 for standard hotplug controller. Valid slots are between 1 and 31.

so this patch is just allowing the above command line to work.  There's
no effect with or without the patch if addr=0, so the patch is good for
2.5 IMO.

Michael, can you queue it?

Paolo