From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Zz4e4-00079j-V5
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:27:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Zz4e1-0004oc-Nv
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:27:40 -0500
Received: from relay.parallels.com ([195.214.232.42]:47787)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Zz4e1-0004oL-Fz
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:27:37 -0500
References: <1447751311-2317-1-git-send-email-den@openvz.org>
	<20151118151551.4570fa06@bahia.local> <87h9kj5qhm.fsf@emacs.mitica>
	<564C910F.1030900@openvz.org> <87wptf2uuy.fsf@emacs.mitica>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <564C98D8.9080303@openvz.org>
Date: Wed, 18 Nov 2015 18:27:20 +0300
MIME-Version: 1.0
In-Reply-To: <87wptf2uuy.fsf@emacs.mitica>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 2.9 v8 0/10] dataplane snapshot fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, Greg Kurz <gkurz@linux.vnet.ibm.com>

On 11/18/2015 06:24 PM, Juan Quintela wrote:
> "Denis V. Lunev" <den@openvz.org> wrote:
>> On 11/18/2015 05:31 PM, Juan Quintela wrote:
>>> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>>>> On Tue, 17 Nov 2015 12:08:20 +0300
>>>> "Denis V. Lunev" <den@openvz.org> wrote:
>>>>
>>>>> with test
>>>>>       while /bin/true ; do
>>>>>           virsh snapshot-create rhel7
>>>>>           sleep 10
>>>>>           virsh snapshot-delete rhel7 --current
>>>>>       done
>>>>> with enabled iothreads on a running VM leads to a lot of troubles: hangs,
>>>>> asserts, errors.
>>>>>
>>>> In my case, when using a virtio-blk-dataplane device, calling savevm *always*
>>>> result in a QEMU hang.
>>> Oops
>>>
>>>> With this series (plus the s/bs/bs_vm_state/ change in patch 11), savevm/loadvm
>>>> now works like a charm.
>>> Nice, thanks for the testing.
>>>
>>>> I saw that Juan does not like aio_context being used in migration code, but
>>>> in case this series gets applied anyway:
>>>>
>>>> Tested-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>>> I *think* that we should get better API's exported from block layer, but
>>> *at least* we will get this series in.
>>>
>>> Thanks, Juan.
>> that is good to me. Current block level API is terrible and unclear.
>>
>> Greg is correct there.
>>
>> Should I resubmit the last patch or you will change this yourself?
> Please, test and resend.
>
> I am not have lots of experience testing that.
>
> Thanks, Juan.
perfect! Give me 2-3 hours pls.