From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4qM-0002De-OF for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:40:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz4qH-0008KR-R8 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:40:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4qH-0008KN-LS for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:40:17 -0500 References: <1447783185-32019-1-git-send-email-berrange@redhat.com> <564B7ACF.30701@redhat.com> <20151118100332.GA27591@redhat.com> From: Eric Blake Message-ID: <564C9BDA.5050405@redhat.com> Date: Wed, 18 Nov 2015 08:40:10 -0700 MIME-Version: 1.0 In-Reply-To: <20151118100332.GA27591@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="axvwwv4be3GrvBc66ukQTvRbKE44AJaUm" Subject: Re: [Qemu-devel] [PATCH] configure: preserve various environment variables in config.status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Peter Maydell , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --axvwwv4be3GrvBc66ukQTvRbKE44AJaUm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/18/2015 03:03 AM, Daniel P. Berrange wrote: >> >> Autoconf preserves CC, CFLAGS, LDFLAGS, LIBS, CPPFLAGS, and CPP by >> default. Also, PKG_CONFIG is typically preserved. If you run libvirt= 's >> './configure --help', you'll also notice a bunch of *_CFLAGS and *_LIB= S >> in the precious list starting under the label "Some influential >> environment variables". >=20 > I'll add in env vars for all the commands like CC, CPP, MAKE, etc that > QEMU's configure uses. I've tried preserving various *FLAGS vars but > the problem here is that configure will modify/augment those variables > while it is running, so when we get to preserve the original flags we > only have the munged version. In any case recommendation is to use > --extra-cflags rather than CFLAGS, so I figure its not a big deal to > skip preserving CFLAGS/LDFLAGS Just one more case where we (perhaps needlessly) diverge from autotools and make distro's life harder. Oh well, it's not your fault that we aren't using CFLAGS like other projects, and not preserving CFLAGS does not change that. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --axvwwv4be3GrvBc66ukQTvRbKE44AJaUm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWTJvaAAoJEKeha0olJ0Nq0QMIAILBeHJSh2zhieK0hYquS/Ag ydGQAzLGJpfh8byod1OouBUAoePMWFzz/lHFbue+NQwgl1MyMRbmDoA2cfPZ95CL 0fKT5rHa51IXk47b/aAbW0+AhdvpMzw8fbwkNB+06efrkCf7iLjCAJJvw+bsE5YN YEV3JM5uxzWHho9UTPaa3qjJTrAABQifLToeIL31PJGU6AHtwT6Ie0Xhr9bnP+T8 FzfMB5xHPz8VTqpf9Y9du2Cxtd4trtUF10nlW2Z8tkP3t12VdMc/pH+kD+AIyrhb iZ45GemqMsq98/L3YcLYVFrA1TC3tvgRt7XoBqMab1O8vTFh0l8B6ax+jUkmijI= =Qz4f -----END PGP SIGNATURE----- --axvwwv4be3GrvBc66ukQTvRbKE44AJaUm--