Re: [Qemu-devel] [PATCH v2] configure: preserve various environment variables in config.status

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]

On 11/18/2015 03:31 AM, Daniel P. Berrange wrote:
> The config.status script is auto-generated by configure upon
> completion. The intention is that config.status can be later
> invoked by the developer to re-detect the same environment
> that configure originally used. The current config.status
> script, however, only contains a record of the command line
> arguments to configure. Various environment variables have
> an effect on what configure will find. In particular the
> PKG_CONFIG_LIBDIR & PKG_CONFIG_PATH vars will affect what
> libraries pkg-config finds. The PATH var will affect what
> toolchain binaries and XXXX-config scripts are found. The
> LD_LIBRARY_PATH var will affect what libraries are found.
> Most commands have env variables that will override the
> name/path of the default version configure finds. All
> these key env variables should be recorded in the
> config.status script.

Would be worth mentioning in the commit message that we are explicitly
deviating from autoconf's practice of preserving CFLAGS.

> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  configure | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/configure b/configure
> index d7472d7..09a503c 100755
> --- a/configure
> +++ b/configure
> @@ -5925,6 +5925,44 @@ cat <<EOD >config.status
>  # Compiler output produced by configure, useful for debugging
>  # configure, is in config.log if it exists.
>  EOD
> +
> +preserve_env() {
> +    envname=$1
> +
> +    eval envval=\$$envname
> +
> +    if test -n "$envval"
> +    then
> +	echo "$envname='$envval'" >> config.status

Works as long as $envval doesn't contain '; I'm not sure if it is worth
worrying about someone compiling in /path/to'evil/location.

> +	echo "export $envname" >> config.status
> +    fi

You missed Stefan Weil's suggestion of an else clause to unset variables
that were added after the fact but not present during the original
configure.  I'm not sure if that matters.

> +}
> +
> +# Preserve various env variables that influence what
> +# features/build target configure will detect
> +preserve_env AR
> +preserve_env AS
> +preserve_env CC
> +preserve_env CPP
> +preserve_env CXX
> +preserve_env INSTALL
> +preserve_env LD
> +preserve_env LD_LIBRARY_PATH
> +preserve_env LIBTOOL
> +preserve_env MAKE
> +preserve_env NM
> +preserve_env OBJCOPY
> +preserve_env PATH
> +preserve_env PKG_CONFIG
> +preserve_env PKG_CONFIG_LIBDIR
> +preserve_env PKG_CONFIG_PATH
> +preserve_env PYTHON
> +preserve_env SDL_CONFIG
> +preserve_env SDL2_CONFIG
> +preserve_env SMBD
> +preserve_env STRIP
> +preserve_env WINDRES
> +
>  printf "exec" >>config.status
>  printf " '%s'" "$0" "$@" >>config.status
>  echo >>config.status
> 

It's better than before, even if we could think of further tweaks.  If
you enhance the commit message, I can live with:
Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]