From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5rd-0007Ps-PN for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:45:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz5ra-0000xs-Fc for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:45:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5ra-0000xn-7R for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:45:42 -0500 References: <1446604018-14025-1-git-send-email-tubo@linux.vnet.ibm.com> <1446604018-14025-2-git-send-email-tubo@linux.vnet.ibm.com> From: Max Reitz Message-ID: <564CAB2F.9060300@redhat.com> Date: Wed, 18 Nov 2015 17:45:35 +0100 MIME-Version: 1.0 In-Reply-To: <1446604018-14025-2-git-send-email-tubo@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ei63xCocaSsTxENxFkrohdW940ksltfx8" Subject: Re: [Qemu-devel] [PATCH v2 1/4] qemu-iotests: refine common.config List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bo Tu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com, mimu@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ei63xCocaSsTxENxFkrohdW940ksltfx8 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.11.2015 03:26, Bo Tu wrote: > Replacing sed with awk, then it's easier to read. I think you meant "awk with sed". > Replacing "[ ! -z "$default_alias_machine" ]" with > "[[ $default_alias_machine ]]", then it's slightly shorter. >=20 > Suggested-By: Sascha Silbe > Reviewed-by: Sascha Silbe > Reviewed-by: Eric Blake > Signed-off-by: Bo Tu > --- > tests/qemu-iotests/common.config | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/comm= on.config > index 596bb2b..08f4b4e 100644 > --- a/tests/qemu-iotests/common.config > +++ b/tests/qemu-iotests/common.config > @@ -128,11 +128,10 @@ export QEMU_IMG=3D_qemu_img_wrapper > export QEMU_IO=3D_qemu_io_wrapper > export QEMU_NBD=3D_qemu_nbd_wrapper > =20 > -default_machine=3D$($QEMU -machine \? | awk '/(default)/{print $1}') > -default_alias_machine=3D$($QEMU -machine \? |\ > - awk -v var_default_machine=3D"$default_machine"\)\ > - '{if ($(NF-2)=3D=3D"(alias"&&$(NF-1)=3D=3D"of"&&$(NF)=3D=3Dvar_def= ault_machine){print $1}}') > -if [ ! -z "$default_alias_machine" ]; then > +default_machine=3D$($QEMU -machine help | sed -n '/(default)/ s/ .*//p= ') > +default_alias_machine=3D$($QEMU -machine help | \ > + sed -n "/(alias of $default_machine)"/' { s/ .*//p; q; }') Could be shortened to "/(alias of $default_machine)/ { s/ .*//p; q; }" (superfluous quotation marks), but that doesn't make it less correct. With the commit message fixed: Reviewed-by: Max Reitz > +if [[ "$default_alias_machine" ]]; then > default_machine=3D"$default_alias_machine" > fi > =20 >=20 --ei63xCocaSsTxENxFkrohdW940ksltfx8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWTKsvAAoJEDuxQgLoOKytuv0H/3jNraLX4TvN2uzIE+fAbg7e TaJaC+HA2ze4IoYNME9WWMbQyZfIaIRCtjkLkie21/i18eVNYawWjvymTPw329Om bqBFWyoI8YNDM+uoX+TrPeylKtHr3L5hS+MqOhMmEDosSFFB6/vZKEaFEaA75LCl cF2NszfZQXdeP9V28BRW4M8U7bSJ9KUhM8bQ/CYugTG6QrXdMfXjd+dk8H9ayJCD gAMWECBy4rmIVBV7tGOGmiqwzxFcWhSNZP548yZRHHq+pcsbeKo5Tkw4PWHuYs3f mKy44kzLxkwmy367Ipj7U0FjrkMfmlzsgHsmYtHEnmnhht2WH8IuM1sqPYMEp+U= =Ma02 -----END PGP SIGNATURE----- --ei63xCocaSsTxENxFkrohdW940ksltfx8--