From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5xs-0003Fo-8K for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:52:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz5xo-0002iW-1Q for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:52:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5xn-0002iR-S3 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:52:07 -0500 References: <1446604018-14025-1-git-send-email-tubo@linux.vnet.ibm.com> <1446604018-14025-3-git-send-email-tubo@linux.vnet.ibm.com> From: Max Reitz Message-ID: <564CACB1.5020806@redhat.com> Date: Wed, 18 Nov 2015 17:52:01 +0100 MIME-Version: 1.0 In-Reply-To: <1446604018-14025-3-git-send-email-tubo@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0CKcrTDt31aikRQAGQpAt7uVVXlKiSkI4" Subject: Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bo Tu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com, mimu@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0CKcrTDt31aikRQAGQpAt7uVVXlKiSkI4 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.11.2015 03:26, Bo Tu wrote: > The tests for device type "ide_cd" should only be tested for the pc > platform. > The default device id of hard disk on the s390 platform differs to that= > of the x86 platform. A new variable device_id is defined and "virtio0" > set for the s390 platform. A x86 platform specific output file is also > needed. > Warning message expected for s390x when drive without device. >=20 > Reviewed-by: Sascha Silbe > Signed-off-by: Bo Tu > --- > tests/qemu-iotests/051 | 99 ++++++---- > tests/qemu-iotests/051.out | 143 +++----------- > tests/qemu-iotests/051.pc.out | 422 ++++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 515 insertions(+), 149 deletions(-) > create mode 100644 tests/qemu-iotests/051.pc.out >=20 [...] > diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out > index 7765aa0..d17c969 100644 > --- a/tests/qemu-iotests/051.out > +++ b/tests/qemu-iotests/051.out [...] > @@ -109,20 +109,23 @@ QEMU X.Y.Z monitor - type 'help' for more informa= tion > =20 > Testing: -drive if=3Dfloppy > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) q=1B[K=1B[Dqu=1B[K=1B[D=1B[Dqui=1B[K=1B[D=1B[D=1B[Dquit=1B[K > +(qemu) Warning: Orphaned drive without device: id=3Dfloppy0,file=3D,if= =3Dfloppy,bus=3D0,unit=3D0 > +q=1B[K=1B[Dqu=1B[K=1B[D=1B[Dqui=1B[K=1B[D=1B[D=1B[Dquit=1B[K I'd still like these warnings to be filtered out (as I wrote in my reply to the original RFC's v4, and as was done in later versions of that RFC (the _filter_orphan function e.g. in http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg04816.html). Looks good other than that. Max --0CKcrTDt31aikRQAGQpAt7uVVXlKiSkI4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWTKyxAAoJEDuxQgLoOKyt8LkIAI4B0aKmcLgVHJ7FlgJfPATo hiVAISfEFitL1GE1dH4/MMaZ8WmDzygwTQ7wb38YbU5uOHEIi7prqNz7FnWczJWb ZZlx3LXa7kQHm64iCWX+XI7D2YAX+2xBlVkRVZsBY7xkT8EJxymbYMDTkYqX8PuQ vamER0gImqinU+7bSPeXEkeGRobxEWqaopSby8yxfQsatCKtOx6NbU/3LQ2z2FO3 +6lPlQtR3cww7tfd0cjxOJcPW9fcbOUETA0JPqZHLmK9fqPdwv1T5B+P8eWbCbXG fkfQ9dJd5R9PIjWfEMwrlpEuER5XSnh5mha2YR0WBDtSNM+01h8wHUY0YJXUzfs= =mqx3 -----END PGP SIGNATURE----- --0CKcrTDt31aikRQAGQpAt7uVVXlKiSkI4--