From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz62P-0005CQ-Pb for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:56:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz62M-0003nx-K5 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:56:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz62M-0003nq-Du for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:56:50 -0500 References: <1446604018-14025-1-git-send-email-tubo@linux.vnet.ibm.com> <1446604018-14025-5-git-send-email-tubo@linux.vnet.ibm.com> From: Max Reitz Message-ID: <564CADCE.30303@redhat.com> Date: Wed, 18 Nov 2015 17:56:46 +0100 MIME-Version: 1.0 In-Reply-To: <1446604018-14025-5-git-send-email-tubo@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OQtAQ4XT8E2VS9H5tq54xQaepeJCG2a9S" Subject: Re: [Qemu-devel] [PATCH v2 4/4] qemu-iotests: disable VNC server for test 120 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bo Tu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com, mimu@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OQtAQ4XT8E2VS9H5tq54xQaepeJCG2a9S Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.11.2015 03:26, Bo Tu wrote: > Ever since qemu-iotest 120 was introduced, its expected output didn't > include the output from the built-in VNC server: >=20 > QA output created by 120 > Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 > QMP_VERSION > +VNC server running on `::1:5900' > {"return": {}} > wrote 65536/65536 bytes at offset 0 > 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >=20 > Since some architectures do not even have a graphical console, we just > pass -nographic to avoid the output. >=20 > Fixes: a68197ff5b11 ("iotests: Add tests for overriding > BDRV_O_PROTOCOL") >=20 > Reviewed-by: Sascha Silbe > Signed-off-by: Bo Tu > --- > tests/qemu-iotests/120 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 > index 9f13078..fb69efd 100755 > --- a/tests/qemu-iotests/120 > +++ b/tests/qemu-iotests/120 > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} > {'execute': 'human-monitor-command', > 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\= "'}} > {'execute': 'quit'}" \ > - | $QEMU -qmp stdio -nodefaults \ > + | $QEMU -qmp stdio -nodefaults -nographic \ > -drive id=3Ddrv,if=3Dnone,file=3D"$TEST_IMG",driver=3Draw,= file.driver=3D$IMGFMT \ > | _filter_qmp | _filter_qemu_io > $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io Looks good, but I think we need the same for 119. Max --OQtAQ4XT8E2VS9H5tq54xQaepeJCG2a9S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWTK3OAAoJEDuxQgLoOKyterMH/3Yldb6BZebqySPDAiGqR3v1 XeqSJhyiSP+UAMPbRe4vzsX75nYtvz6ZVSaaQHSUkZt5OMXpGaIcbNUo2nBRpm+Q H5upEBlaicdEjfcPA6XYAtK7JvGpwTDEYctFdmmYu2rHE7CFzx6ANCgenbu59PpX /aIbMveKcgmGzrvxMWiJXr3ad2pvHb/rzHG8yyBwtaNLhRLpuq3WZtCQlst/IWYZ YkHn4Cb5WkXuBaaTLdyDV2crqG6AdSYIEKzcGlshIyMUjoe5E/t4n12ttgvVj23e xl2IArYgd0hot24APrOa920omyMZqTiZBH8xAxtCmnUNbEaY0VTKXEnYXwTRh5Q= =5/Ru -----END PGP SIGNATURE----- --OQtAQ4XT8E2VS9H5tq54xQaepeJCG2a9S--