From: Max Reitz <mreitz@redhat.com>
To: Bo Tu <tubo@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com,
mimu@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] qemu-iotests: s390x: fix test 068
Date: Wed, 18 Nov 2015 17:57:38 +0100 [thread overview]
Message-ID: <564CAE02.3040906@redhat.com> (raw)
In-Reply-To: <1446604018-14025-4-git-send-email-tubo@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On 04.11.2015 03:26, Bo Tu wrote:
> Now, s390-virtio-ccw is default machine and s390-ccw.img is default boot
> loader. If the s390-virtio-ccw machine finds no device to load from and
> errors out, then emits a panic and exits the vm. This breaks test cases
> 068 for s390x.
> Adding the parameter of "-no-shutdown" for s390-ccw-virtio will pause VM
> before shutdown.
>
> Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
> Signed-off-by: Bo Tu <tubo@linux.vnet.ibm.com>
> ---
> tests/qemu-iotests/068 | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Acked-by: Max Reitz <mreitz@redhat.com>
(I have no way of verifying that this patch fixes this test for said
machine type, so I cannot give an R-b.)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-18 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 2:26 [Qemu-devel] [PATCH v2 0/4] Update tests/qemu-iotests failing cases for the s390 platform Bo Tu
2015-11-04 2:26 ` [Qemu-devel] [PATCH v2 1/4] qemu-iotests: refine common.config Bo Tu
2015-11-18 16:45 ` Max Reitz
2015-11-19 5:58 ` tu bo
2015-11-04 2:26 ` [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051 Bo Tu
2015-11-18 16:52 ` Max Reitz
2015-11-19 7:28 ` tu bo
2015-11-20 16:24 ` Max Reitz
2015-11-23 3:34 ` tu bo
2015-11-24 21:17 ` Sascha Silbe
2015-11-25 15:41 ` Max Reitz
2015-11-26 10:15 ` tu bo
2015-11-04 2:26 ` [Qemu-devel] [PATCH v2 3/4] qemu-iotests: s390x: fix test 068 Bo Tu
2015-11-18 16:57 ` Max Reitz [this message]
2015-11-04 2:26 ` [Qemu-devel] [PATCH v2 4/4] qemu-iotests: disable VNC server for test 120 Bo Tu
2015-11-18 16:56 ` Max Reitz
2015-11-19 7:06 ` tu bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CAE02.3040906@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
--cc=tubo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).