Re: [Qemu-devel] [PULL 37/40] Add David Gibson for sPAPR in MAINTAINERS file

["Andreas Färber" <afaerber@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

Am 18.11.2015 um 21:51 schrieb Eric Blake:
> On 11/18/2015 01:46 PM, Andreas Färber wrote:
>>> +++ b/MAINTAINERS
>>> @@ -486,7 +486,8 @@ F: hw/ppc/prep.c
>>>  F: hw/pci-host/prep.[hc]
>>>  F: hw/isa/pc87312.[hc]
>>>  
>>> -sPAPR
>>> +sPAPR (pseries)
>>
>> This change leads to get_maintainer.pl using "qemu-ppc@nongnu.org (open
>> list:sPAPR (pseries))", which results in:
>>
>> 5.1.3 Bad recipient address syntax
>>
>>> +M: David Gibson <david@gibson.dropbear.id.au>
>>>  M: Alexander Graf <agraf@suse.de>
>>>  L: qemu-ppc@nongnu.org
>>
>> Changing this to
>>
>> L: qemu-ppc <qemu-ppc@nongnu.org>
>>
>> I am instead asked:
>>
>> (cc-cmd) Adding cc: (open list:sPAPR (pseries)) from:
>> 'scripts/get_maintainer.pl --nogit-fallback'
>> (cc-cmd) Adding cc: qemu-ppc@nongnu.org (open list:PowerPC) from:
>> 'scripts/get_maintainer.pl --nogit-fallback'
>> error: unable to extract a valid address from: ")"  (open list:sPAPR
>> (pseries)
>> What to do with this address? ([q]uit|[d]rop|[e]dit):
>>
>>>  S: Supported
>>
>> While this is not the only MAINTAINERS section with parenthesis in the
>> title, it is the only one to have an L: entry in that section.
> 
> Does using a section title of "sPAPR (pseries)" (with the quotes present
> in the file) make a difference?

--dry-run did not show an error before, but with title quotes instead of
<qemu-ppc> ...

diff --git a/MAINTAINERS b/MAINTAINERS
index 28f0139..4971f41 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -579,7 +579,7 @@ F: hw/ppc/prep.c
 F: hw/pci-host/prep.[hc]
 F: hw/isa/pc87312.[hc]

-sPAPR (pseries)
+"sPAPR (pseries)"
 M: David Gibson <david@gibson.dropbear.id.au>
 M: Alexander Graf <agraf@suse.de>
 L: qemu-ppc@nongnu.org

... --dry-run does not look promising:

Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>,
	qemu-ppc@nongnu.org") (open list:"sPAPR (pseries)

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]