From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzC8M-0005KZ-G5 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 18:27:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzC8L-0005oK-KF for qemu-devel@nongnu.org; Wed, 18 Nov 2015 18:27:26 -0500 References: <1447836791-369-1-git-send-email-eblake@redhat.com> <1447836791-369-30-git-send-email-eblake@redhat.com> <87mvubjhbl.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <564D0952.9010306@redhat.com> Date: Wed, 18 Nov 2015 16:27:14 -0700 MIME-Version: 1.0 In-Reply-To: <87mvubjhbl.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vQIG7brAeJN9j79dm7ADsOG9QIQXx4dqL" Subject: Re: [Qemu-devel] [PATCH v12 29/36] qobject: Rename qtype_code to QType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Luiz Capitulino , qemu-devel@nongnu.org, "open list:Block layer core" , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vQIG7brAeJN9j79dm7ADsOG9QIQXx4dqL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/18/2015 11:25 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> The name QType is more in line with our conventions for qapi >> types, and matches the fact that each enum member has a prefix >> of QTYPE_. >> >> Signed-off-by: Eric Blake >=20 > At this point, the connection to QAPI is unobvious. >=20 > You can either point to CODING_STYLE, which ask for type names in > CamelCase, or to the next patch. How about: The name QType matches our CODING_STYLE conventions for type names in CamelCase. It also matches the fact that we are already naming all the enum members with a prefix of QTYPE, not QTYPE_CODE. And doing the rename will also make it easier for the next patch to use QAPI for the enum, which also wants CamelCase type names. Feel free to touch up the commit message as you see fit. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vQIG7brAeJN9j79dm7ADsOG9QIQXx4dqL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWTQlSAAoJEKeha0olJ0Nqoy8H/2QMMK9d/oIxJ2U1ZGozKwBf pARh1Zm8ddmTqDEQPGIud6jLQYmcwuo/sAletRFSrguqkYDhblussLvjcC8srFd+ Ec8ClXTmA9xDdong/WRxnav4PkC+aEr3vAy4VAHtFSLnBeJtBYrK7Z02ln92Y8be U3zWQkkpmCOih6dia1FOMjFxdvQo3QOA0EfJBeBE76S2oKjw1DxvTSTgcEBA5oKS QuvmZGQaG5gyekj24PwE4IYvYckMQoh/8uH2n1nVWlO9hOj4NhgPAHrcTHc5hkcC qgCUJBX+C16WC5WTVi/qIfpNnwroIykiVcsFjB2Ykivt8ww46ccEMhADcaSDNMI= =gLM9 -----END PGP SIGNATURE----- --vQIG7brAeJN9j79dm7ADsOG9QIQXx4dqL--