From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzFEI-0004mt-Tb for qemu-devel@nongnu.org; Wed, 18 Nov 2015 21:45:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzFED-0000xj-Uz for qemu-devel@nongnu.org; Wed, 18 Nov 2015 21:45:46 -0500 Received: from mga09.intel.com ([134.134.136.24]:48361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzFED-0000xZ-Ok for qemu-devel@nongnu.org; Wed, 18 Nov 2015 21:45:41 -0500 References: <1447671063-92665-1-git-send-email-guangrong.xiao@linux.intel.com> <564BDB86.6060404@linux.intel.com> <20151118191817.GK20436@thinpad.lan.raisama.net> <20151118224253-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <564D3649.6080007@linux.intel.com> Date: Thu, 19 Nov 2015 10:39:05 +0800 MIME-Version: 1.0 In-Reply-To: <20151118224253-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Eduardo Habkost Cc: kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/19/2015 04:44 AM, Michael S. Tsirkin wrote: > On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote: >> On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote: >>> >>> Ping... >>> >>> Do you have any comment on this patchset? Could it be applied to somewhere >>> if it is okay for you? >> >> I have no additional comments, as the memory-backend patches I >> was reviewing are not included in this version. I didn't take the >> time to review the TYPE_NVDIMM and ACPI changes. > > No, I don't think the way guest memory is allocated here is ok. I'm Since the DSM memory/ACPI memory was not included in this patchset, i really do not understand what is "guest memory is allocated" exactly stands for... > sorry, I'm busy with 2.5 now, and this is clearly not 2.5 material. I still see some pull requests were send our for 2.5 merge window today and yesterday ... This patchset is the simplest version we can figure out to implement basic functionality for vNVDIMM and only minor change is needed for other code. It would be nice and really appreciate if it can go to 2.5. > Once that's out, I'll post some suggestions. Look forward to you suggestions. Thanks for your time, Michael and Eduardo!