From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzJIs-0008H9-8R for qemu-devel@nongnu.org; Thu, 19 Nov 2015 02:06:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzJIo-000435-70 for qemu-devel@nongnu.org; Thu, 19 Nov 2015 02:06:46 -0500 Received: from e18.ny.us.ibm.com ([129.33.205.208]:54554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzJIo-000431-3H for qemu-devel@nongnu.org; Thu, 19 Nov 2015 02:06:42 -0500 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Nov 2015 02:06:41 -0500 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 47B87C9003E for ; Thu, 19 Nov 2015 01:54:48 -0500 (EST) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAJ76cEt61997232 for ; Thu, 19 Nov 2015 07:06:38 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAJ76bNH014758 for ; Thu, 19 Nov 2015 02:06:38 -0500 References: <1446604018-14025-1-git-send-email-tubo@linux.vnet.ibm.com> <1446604018-14025-5-git-send-email-tubo@linux.vnet.ibm.com> <564CADCE.30303@redhat.com> From: tu bo Message-ID: <564D74FA.3030505@linux.vnet.ibm.com> Date: Thu, 19 Nov 2015 15:06:34 +0800 MIME-Version: 1.0 In-Reply-To: <564CADCE.30303@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] qemu-iotests: disable VNC server for test 120 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mimu@linux.vnet.ibm.com, armbru@redhat.com, silbe@linux.vnet.ibm.com Hi Max: On 11/19/2015 12:56 AM, Max Reitz wrote: > On 04.11.2015 03:26, Bo Tu wrote: >> Ever since qemu-iotest 120 was introduced, its expected output didn't >> include the output from the built-in VNC server: >> >> QA output created by 120 >> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 >> QMP_VERSION >> +VNC server running on `::1:5900' >> {"return": {}} >> wrote 65536/65536 bytes at offset 0 >> 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> >> Since some architectures do not even have a graphical console, we just >> pass -nographic to avoid the output. >> >> Fixes: a68197ff5b11 ("iotests: Add tests for overriding >> BDRV_O_PROTOCOL") >> >> Reviewed-by: Sascha Silbe >> Signed-off-by: Bo Tu >> --- >> tests/qemu-iotests/120 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 >> index 9f13078..fb69efd 100755 >> --- a/tests/qemu-iotests/120 >> +++ b/tests/qemu-iotests/120 >> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} >> {'execute': 'human-monitor-command', >> 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}} >> {'execute': 'quit'}" \ >> - | $QEMU -qmp stdio -nodefaults \ >> + | $QEMU -qmp stdio -nodefaults -nographic \ >> -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ >> | _filter_qmp | _filter_qemu_io >> $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io > > Looks good, but I think we need the same for 119. I agree with you that 119 need to add the parameter of "-nographic" at line 53. 52 | $QEMU -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \ 53 -qmp stdio -nodefaults \ > > Max >