From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzMOF-0004av-AW for qemu-devel@nongnu.org; Thu, 19 Nov 2015 05:24:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzMOA-0007jt-9g for qemu-devel@nongnu.org; Thu, 19 Nov 2015 05:24:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:53155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzMOA-0007jh-40 for qemu-devel@nongnu.org; Thu, 19 Nov 2015 05:24:26 -0500 References: <1447879178-5440-1-git-send-email-afaerber@suse.de> <1447879178-5440-3-git-send-email-afaerber@suse.de> <87vb8ybb1l.fsf@blackfin.pond.sub.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <564DA358.4060501@suse.de> Date: Thu, 19 Nov 2015 11:24:24 +0100 MIME-Version: 1.0 In-Reply-To: <87vb8ybb1l.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Am 19.11.2015 um 10:20 schrieb Markus Armbruster: > Andreas F=C3=A4rber writes: >=20 >> From: "Daniel P. Berrange" >> >> Some users of QOM need to be able to iterate over properties >> defined against an object instance. Currently they are just >> directly using the QTAIL macros against the object properties >> data structure. >> >> This is bad because it exposes them to changes in the data >> structure used to store properties, as well as changes in >> functionality such as ability to register properties against >> the class. >> >> This provides an ObjectPropertyIterator struct which will >> insulate the callers from the particular data structure >> used to store properties. It can be used thus >> >> ObjectProperty *prop; >> ObjectPropertyIterator *iter; >> >> iter =3D object_property_iter_init(obj); >> while ((prop =3D object_property_iter_next(iter))) { >> ... do something with prop ... >> } >> object_property_iter_free(iter); >=20 > I see my review hasn't been addressed, Well, it has, I double-checked that the missing "Iterator" above was already on my branch, therefore my IRC comment pointing you to qom-next. > probably because it came late. Other than that you only seemed to discuss design alternatives, for which neither you nor Daniel provided any actual patch I could've applied. While I regularly do style fixups myself, and with the series missing -rc0 also functional fixes, posting a diff for review/record, I do not see redesigning a 6-patch series as something I can silently do last-minute without full respin, for which -rc1 did not leave time. There was a v3 with iterators, and Pavel pinged v4 twice, I did once too, and the last delay after getting the series to work was only due to me inserting Daniel's test case (legit hardfreeze material), so ... > Would you accept a follow-up patch to bring the iterator into line with > existing ones? ... yes, from my perspective any such cleanups can be done post-2.5. Please note that both patch 6/7 (included) and 7/7 (not in this pull) enhance the iterator, so follow-up patches should be based on qom-next please. Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg)