From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzN7J-0008RT-6h for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:11:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzN7D-0004QZ-Bb for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:11:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzN7D-0004QV-69 for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:10:59 -0500 References: <1447813217-10532-1-git-send-email-huaitong.han@intel.com> <1447813217-10532-2-git-send-email-huaitong.han@intel.com> <20151118155855.GI20436@thinpad.lan.raisama.net> <1447915017.3961.22.camel@intel.com> From: Paolo Bonzini Message-ID: <564DAE39.3050203@redhat.com> Date: Thu, 19 Nov 2015 12:10:49 +0100 MIME-Version: 1.0 In-Reply-To: <1447915017.3961.22.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Han, Huaitong" , "ehabkost@redhat.com" Cc: "afaerber@suse.de" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "rth@twiddle.net" On 19/11/2015 07:36, Han, Huaitong wrote: > I understand it has always been that QEMU considers the feature of > cpuid_7_0_ecx_feature_name as migratable. If the feature is > unmigratable, it will been added to unmigratable_flags. > > A series of patches do complete a full function, moving > cpuid_7_0_ecx_feature_name to 2/3 patch may make 2/3 patch look > better, but make 1/3 patch look somewhat incomplete. > > Maybe it is a solution that adding the feature to unmigratable_flags in > 1/3 patch, and deleting unmigratable_flags in 2/3 patch, but I think it > is pointless. Or just squash everything together. After all we're talking of 4 files changed, 55 insertions(+), 1 deletion(-) It's not a large patch. Paolo