From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Fedin <p.fedin@samsung.com>,
"'Michael S. Tsirkin'" <mst@redhat.com>
Cc: 'Cornelia Huck' <cornelia.huck@de.ibm.com>,
'Christian Borntraeger' <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio: Implement userspace forwarding for host notifiers
Date: Thu, 19 Nov 2015 13:31:54 +0100 [thread overview]
Message-ID: <564DC13A.2020208@redhat.com> (raw)
In-Reply-To: <014e01d122c4$54073d30$fc15b790$@samsung.com>
On 19/11/2015 13:17, Pavel Fedin wrote:
> Ok, good. So, this has already been tested. Ok, i think i can further extend this patch by:
> 1. Add a flag to disable memory_region_dispatch_write_ioeventfds(), to be set by KVM code for example. So that with KVM we have even
> smaller performance degradation.
> 2. Issue a one-shot warning, like in my current patch, so that the user knows that his/her kernel prevents from getting the best
> performance.
> Will it be OK then?
Yes! However QEMU pretty much always tries to use ioeventfd for virtio.
I'm not sure you want to warn outside the special cases of vhost or
dataplane... So perhaps it's better to warn in the vhost and dataplane
case specifically, rather than always.
Paolo
next prev parent reply other threads:[~2015-11-19 12:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 9:50 [Qemu-devel] [PATCH] virtio: Implement userspace forwarding for host notifiers Pavel Fedin
2015-11-19 9:56 ` Christian Borntraeger
2015-11-19 10:18 ` Pavel Fedin
2015-11-19 11:41 ` Cornelia Huck
2015-11-19 12:02 ` Pavel Fedin
2015-11-19 12:05 ` Michael S. Tsirkin
2015-11-19 10:55 ` Michael S. Tsirkin
2015-11-19 11:44 ` Pavel Fedin
2015-11-19 12:01 ` Michael S. Tsirkin
2015-11-19 12:06 ` Paolo Bonzini
2015-11-19 12:10 ` Michael S. Tsirkin
2015-11-19 12:17 ` Pavel Fedin
2015-11-19 12:31 ` Paolo Bonzini [this message]
2015-11-19 12:55 ` Cornelia Huck
2015-11-19 16:03 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DC13A.2020208@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).