* [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 @ 2015-11-20 9:35 Fam Zheng 2015-11-20 16:17 ` Max Reitz 0 siblings, 1 reply; 6+ messages in thread From: Fam Zheng @ 2015-11-20 9:35 UTC (permalink / raw) To: qemu-devel; +Cc: Kevin Wolf, qemu-block, mreitz Otherwise, a window flashes on my desktop (built with SDL). Other iotest cases have that. Signed-off-by: Fam Zheng <famz@redhat.com> --- tests/qemu-iotests/120 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 index 9f13078..d899a3f 100755 --- a/tests/qemu-iotests/120 +++ b/tests/qemu-iotests/120 @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} {'execute': 'human-monitor-command', 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}} {'execute': 'quit'}" \ - | $QEMU -qmp stdio -nodefaults \ + | $QEMU -qmp stdio -nographic -nodefaults \ -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ | _filter_qmp | _filter_qemu_io $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io -- 2.4.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 2015-11-20 9:35 [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 Fam Zheng @ 2015-11-20 16:17 ` Max Reitz 2015-11-23 2:29 ` tu bo 0 siblings, 1 reply; 6+ messages in thread From: Max Reitz @ 2015-11-20 16:17 UTC (permalink / raw) To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, qemu-block [-- Attachment #1: Type: text/plain, Size: 1416 bytes --] On 20.11.2015 10:35, Fam Zheng wrote: > Otherwise, a window flashes on my desktop (built with SDL). Other > iotest cases have that. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > tests/qemu-iotests/120 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 > index 9f13078..d899a3f 100755 > --- a/tests/qemu-iotests/120 > +++ b/tests/qemu-iotests/120 > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} > {'execute': 'human-monitor-command', > 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}} > {'execute': 'quit'}" \ > - | $QEMU -qmp stdio -nodefaults \ > + | $QEMU -qmp stdio -nographic -nodefaults \ > -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ > | _filter_qmp | _filter_qemu_io > $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io > This is the same patch as http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.html, but while both are correct, both need to fix 119, too, I think. (And while I would be fine with merging this and then taking a follow-up patch, I don't think we need to hurry for 2.5. Releases and iotests don't really care about each other, other than that we should pass all the iotests before a release unless we know what's wrong and don't care.) Max [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 2015-11-20 16:17 ` Max Reitz @ 2015-11-23 2:29 ` tu bo 2015-11-23 2:33 ` Fam Zheng 0 siblings, 1 reply; 6+ messages in thread From: tu bo @ 2015-11-23 2:29 UTC (permalink / raw) To: Max Reitz, Fam Zheng, qemu-devel; +Cc: Kevin Wolf, qemu-block Hi Max: On 11/21/2015 12:17 AM, Max Reitz wrote: > On 20.11.2015 10:35, Fam Zheng wrote: >> Otherwise, a window flashes on my desktop (built with SDL). Other >> iotest cases have that. >> >> Signed-off-by: Fam Zheng <famz@redhat.com> >> --- >> tests/qemu-iotests/120 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 >> index 9f13078..d899a3f 100755 >> --- a/tests/qemu-iotests/120 >> +++ b/tests/qemu-iotests/120 >> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} >> {'execute': 'human-monitor-command', >> 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}} >> {'execute': 'quit'}" \ >> - | $QEMU -qmp stdio -nodefaults \ >> + | $QEMU -qmp stdio -nographic -nodefaults \ >> -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ >> | _filter_qmp | _filter_qemu_io >> $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io >> > > This is the same patch as > http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.html, > but while both are correct, both need to fix 119, too, I think. > > (And while I would be fine with merging this and then taking a follow-up > patch, I don't think we need to hurry for 2.5. Releases and iotests > don't really care about each other, other than that we should pass all > the iotests before a release unless we know what's wrong and don't care.) > thanks for your advice. I plan to fix 119 in a follow-up patch. currently, 119 is notrun for s390x, and I hope to spend some time to investigate it later. > Max > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 2015-11-23 2:29 ` tu bo @ 2015-11-23 2:33 ` Fam Zheng 2015-11-23 3:12 ` tu bo 0 siblings, 1 reply; 6+ messages in thread From: Fam Zheng @ 2015-11-23 2:33 UTC (permalink / raw) To: tu bo; +Cc: Kevin Wolf, qemu-devel, qemu-block, Max Reitz On Mon, 11/23 10:29, tu bo wrote: > Hi Max: > > On 11/21/2015 12:17 AM, Max Reitz wrote: > >On 20.11.2015 10:35, Fam Zheng wrote: > >>Otherwise, a window flashes on my desktop (built with SDL). Other > >>iotest cases have that. > >> > >>Signed-off-by: Fam Zheng <famz@redhat.com> > >>--- > >> tests/qemu-iotests/120 | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 > >>index 9f13078..d899a3f 100755 > >>--- a/tests/qemu-iotests/120 > >>+++ b/tests/qemu-iotests/120 > >>@@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} > >> {'execute': 'human-monitor-command', > >> 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}} > >> {'execute': 'quit'}" \ > >>- | $QEMU -qmp stdio -nodefaults \ > >>+ | $QEMU -qmp stdio -nographic -nodefaults \ > >> -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ > >> | _filter_qmp | _filter_qemu_io > >> $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io > >> > > > >This is the same patch as > >http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.html, > >but while both are correct, both need to fix 119, too, I think. > > > >(And while I would be fine with merging this and then taking a follow-up > >patch, I don't think we need to hurry for 2.5. Releases and iotests > >don't really care about each other, other than that we should pass all > >the iotests before a release unless we know what's wrong and don't care.) > > > > thanks for your advice. I plan to fix 119 in a follow-up patch. > currently, 119 is notrun for s390x, and I hope to spend some time to > investigate it later. > I'm sending a new version fixing both scripts. Fam ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 2015-11-23 2:33 ` Fam Zheng @ 2015-11-23 3:12 ` tu bo 2015-11-23 17:08 ` Max Reitz 0 siblings, 1 reply; 6+ messages in thread From: tu bo @ 2015-11-23 3:12 UTC (permalink / raw) To: Fam Zheng, Max Reitz; +Cc: Kevin Wolf, qemu-devel, qemu-block Hi Fam, Max: On 11/23/2015 10:33 AM, Fam Zheng wrote: > On Mon, 11/23 10:29, tu bo wrote: >> Hi Max: >> >> On 11/21/2015 12:17 AM, Max Reitz wrote: >>> On 20.11.2015 10:35, Fam Zheng wrote: >>>> Otherwise, a window flashes on my desktop (built with SDL). Other >>>> iotest cases have that. >>>> >>>> Signed-off-by: Fam Zheng <famz@redhat.com> >>>> --- >>>> tests/qemu-iotests/120 | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 >>>> index 9f13078..d899a3f 100755 >>>> --- a/tests/qemu-iotests/120 >>>> +++ b/tests/qemu-iotests/120 >>>> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} >>>> {'execute': 'human-monitor-command', >>>> 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}} >>>> {'execute': 'quit'}" \ >>>> - | $QEMU -qmp stdio -nodefaults \ >>>> + | $QEMU -qmp stdio -nographic -nodefaults \ >>>> -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ >>>> | _filter_qmp | _filter_qemu_io >>>> $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io >>>> >>> >>> This is the same patch as >>> http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.html, >>> but while both are correct, both need to fix 119, too, I think. >>> >>> (And while I would be fine with merging this and then taking a follow-up >>> patch, I don't think we need to hurry for 2.5. Releases and iotests >>> don't really care about each other, other than that we should pass all >>> the iotests before a release unless we know what's wrong and don't care.) >>> >> >> thanks for your advice. I plan to fix 119 in a follow-up patch. >> currently, 119 is notrun for s390x, and I hope to spend some time to >> investigate it later. >> > > I'm sending a new version fixing both scripts. Good news. Hi Max: If it's fine to you, I'll remove patch for 120 from my patch set. thanks > > Fam > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 2015-11-23 3:12 ` tu bo @ 2015-11-23 17:08 ` Max Reitz 0 siblings, 0 replies; 6+ messages in thread From: Max Reitz @ 2015-11-23 17:08 UTC (permalink / raw) To: tu bo, Fam Zheng; +Cc: Kevin Wolf, qemu-devel, qemu-block [-- Attachment #1: Type: text/plain, Size: 2181 bytes --] On 23.11.2015 04:12, tu bo wrote: > Hi Fam, Max: > > On 11/23/2015 10:33 AM, Fam Zheng wrote: >> On Mon, 11/23 10:29, tu bo wrote: >>> Hi Max: >>> >>> On 11/21/2015 12:17 AM, Max Reitz wrote: >>>> On 20.11.2015 10:35, Fam Zheng wrote: >>>>> Otherwise, a window flashes on my desktop (built with SDL). Other >>>>> iotest cases have that. >>>>> >>>>> Signed-off-by: Fam Zheng <famz@redhat.com> >>>>> --- >>>>> tests/qemu-iotests/120 | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 >>>>> index 9f13078..d899a3f 100755 >>>>> --- a/tests/qemu-iotests/120 >>>>> +++ b/tests/qemu-iotests/120 >>>>> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} >>>>> {'execute': 'human-monitor-command', >>>>> 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 >>>>> 64k\"'}} >>>>> {'execute': 'quit'}" \ >>>>> - | $QEMU -qmp stdio -nodefaults \ >>>>> + | $QEMU -qmp stdio -nographic -nodefaults \ >>>>> -drive >>>>> id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \ >>>>> | _filter_qmp | _filter_qemu_io >>>>> $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io >>>>> >>>> >>>> This is the same patch as >>>> http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.html, >>>> but while both are correct, both need to fix 119, too, I think. >>>> >>>> (And while I would be fine with merging this and then taking a >>>> follow-up >>>> patch, I don't think we need to hurry for 2.5. Releases and iotests >>>> don't really care about each other, other than that we should pass all >>>> the iotests before a release unless we know what's wrong and don't >>>> care.) >>>> >>> >>> thanks for your advice. I plan to fix 119 in a follow-up patch. >>> currently, 119 is notrun for s390x, and I hope to spend some time to >>> investigate it later. >>> >> >> I'm sending a new version fixing both scripts. > > Good news. > > Hi Max: > > If it's fine to you, I'll remove patch for 120 from my patch set. thanks Yep, that's completely fine, of course. Max [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-23 17:09 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-20 9:35 [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 Fam Zheng 2015-11-20 16:17 ` Max Reitz 2015-11-23 2:29 ` tu bo 2015-11-23 2:33 ` Fam Zheng 2015-11-23 3:12 ` tu bo 2015-11-23 17:08 ` Max Reitz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).