From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzolc-0008Vv-I7 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:42:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzolY-00059h-A8 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:42:32 -0500 Message-ID: <564F4D6C.9080609@virtuozzo.com> Date: Fri, 20 Nov 2015 19:42:20 +0300 From: Vladimir Sementsov-Ogievskiy MIME-Version: 1.0 References: <1448013593-14282-1-git-send-email-famz@redhat.com> In-Reply-To: <1448013593-14282-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for 2.6 0/3] Bitmap clean-up patches for 2.6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , mreitz@redhat.com, pbonzini@redhat.com, jsnow@redhat.com Hi Fam! Thanks for it, I really like the idea about dropping granularity from hbitmap. I've waste lots of time understanding the code about bitmaps. Keeping in mind what units are in what granularity and what granularity is in what units is more than inconvenient) On 20.11.2015 12:59, Fam Zheng wrote: > This makes a cleaner base for more dirty bitmap work. "granularity" appearing > with different representations have always been mind twisting, remove it from > HBitmap to make the interface and implementation simpler. Upon this, it is > a bit easier to add persistent dirty bitmap functionalities. > > Block dirty bitmap is not unit-tested, so the removal of HBitmap test code > looks like a loss, but the overall test coverage is barely affected as we also > have various mirror, commit and backup iotest cases, and they do catch various > bugs when I wrote the patches. > > Please review! > > Fam > > Fam Zheng (3): > backup: Use Bitmap to replace "s->bitmap" > block: Hide HBitmap in block dirty bitmap interface > hbitmap: Drop "granularity" > > block.c | 79 ++++++++++++++----- > block/backup.c | 25 +++--- > block/mirror.c | 14 ++-- > include/block/block.h | 9 ++- > include/qemu/hbitmap.h | 20 +---- > tests/test-hbitmap.c | 206 ++++++++----------------------------------------- > util/hbitmap.c | 64 +++------------ > 7 files changed, 135 insertions(+), 282 deletions(-) > -- Best regards, Vladimir * now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.