From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzotp-0004DQ-FU for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:51:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zzoto-0007jA-N5 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:51:01 -0500 References: <1448029742-19771-1-git-send-email-pl@kamp.de> From: John Snow Message-ID: <564F4F6E.2090801@redhat.com> Date: Fri, 20 Nov 2015 11:50:54 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Peter Lieven Cc: Kevin Wolf , QEMU Developers , Qemu-block On 11/20/2015 09:37 AM, Peter Maydell wrote: > On 20 November 2015 at 14:29, Peter Lieven wrote: >> The check for the cleared BSY flag has to be performed >> before each data transfer and not just before the >> first one. >> >> Commit 5f81724d revealed this glitch as the BSY flag >> was not set in ATAPI PIO transfers before. >> >> While at it fix the desciptions and add a comment before >> the nested for loop that transfers the data. >> >> Signed-off-by: Peter Lieven > > If the IDE folks can review this I'd like to apply it > direct to master this afternoon so we can tag and roll rc1 > today. > > thanks > -- PMM > Please do. --js