From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] qjson: store tokens in a GQueue
Date: Fri, 20 Nov 2015 11:40:22 -0700 [thread overview]
Message-ID: <564F6916.8030807@redhat.com> (raw)
In-Reply-To: <1448010269-21694-4-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On 11/20/2015 02:04 AM, Paolo Bonzini wrote:
> Even though we still have the "streamer" concept, the tokens can now
> be deleted as they are read. While doing so convert from QList to
> GQueue, since the next step will make tokens not a QObject and we
> will have to do the conversion anyway.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/qapi/qmp/json-parser.h | 4 +--
> include/qapi/qmp/json-streamer.h | 8 ++---
> monitor.c | 2 +-
> qga/main.c | 2 +-
> qobject/json-parser.c | 65 +++++++++++++---------------------------
> qobject/json-streamer.c | 25 +++++++++-------
> qobject/qjson.c | 2 +-
> tests/libqtest.c | 2 +-
> 8 files changed, 45 insertions(+), 65 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-20 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 9:04 [Qemu-devel] [PATCH 0/4] qjson: save a lot of memory Paolo Bonzini
2015-11-20 9:04 ` [Qemu-devel] [PATCH 1/4] qjson: replace QString in JSONLexer with GString Paolo Bonzini
2015-11-20 18:23 ` Eric Blake
2015-11-20 20:16 ` Paolo Bonzini
2015-11-20 9:04 ` [Qemu-devel] [PATCH 2/4] qjson: do not save/restore contexts Paolo Bonzini
2015-11-20 18:28 ` Eric Blake
2015-11-20 20:17 ` Paolo Bonzini
2015-11-20 9:04 ` [Qemu-devel] [PATCH 3/4] qjson: store tokens in a GQueue Paolo Bonzini
2015-11-20 18:40 ` Eric Blake [this message]
2015-11-20 9:04 ` [Qemu-devel] [PATCH 4/4] qjson: surprise, allocating 6 QObjects per token is expensive Paolo Bonzini
2015-11-20 18:48 ` Eric Blake
2015-11-20 20:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F6916.8030807@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).