From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZztZV-0005es-AK for qemu-devel@nongnu.org; Fri, 20 Nov 2015 16:50:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZztZR-0001Wz-9f for qemu-devel@nongnu.org; Fri, 20 Nov 2015 16:50:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZztZR-0001WT-27 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 16:50:17 -0500 References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com> <1446551816-15768-24-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <564F9592.7000200@redhat.com> Date: Fri, 20 Nov 2015 14:50:10 -0700 MIME-Version: 1.0 In-Reply-To: <1446551816-15768-24-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sxlGgnRandMIIjDAkRh9dNEO0iKtfmbo9" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 23/38] qmp event: Add event notification for COLO error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Markus Armbruster , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sxlGgnRandMIIjDAkRh9dNEO0iKtfmbo9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/03/2015 04:56 AM, zhanghailiang wrote: > If some errors happen during VM's COLO FT stage, it's important to noti= fy the users > of this event. Together with 'colo_lost_heartbeat', users can intervene= in COLO's > failover work immediately. > If users don't want to get involved in COLO's failover verdict, > it is still necessary to notify users that we exit COLO mode. s/exit/exited/ >=20 > Cc: Markus Armbruster > Cc: Michael Roth > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > --- > docs/qmp-events.txt | 17 +++++++++++++++++ > migration/colo.c | 13 +++++++++++++ > qapi-schema.json | 16 ++++++++++++++++ > qapi/event.json | 17 +++++++++++++++++ > 4 files changed, 63 insertions(+) >=20 > diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt > index d2f1ce4..165dd76 100644 > --- a/docs/qmp-events.txt > +++ b/docs/qmp-events.txt > @@ -184,6 +184,23 @@ Example: > Note: The "ready to complete" status is always reset by a BLOCK_JOB_ER= ROR > event. > =20 > +COLO_EXIT > +--------- > + > +Emitted when VM finishes COLO mode due to some errors happening or > +the request of users. s/the/at the/ > +++ b/qapi-schema.json > @@ -751,6 +751,22 @@ > 'data': [ 'unknown', 'primary', 'secondary'] } > =20 > ## > +# @COLOExitReason > +# > +# The reason of COLO exit s/of/for a/ > +# > +# @unknow: unknown reason s/unknow/unknown/ > +# > +# @request: COLO exit is due to an external request > +# > +# @error: COLO exit is due to an internal error > +# > +# Since: 2.5 2.6 (but you already know that throughout the series, so I'll quit pointing it out) > +++ b/qapi/event.json > @@ -255,6 +255,23 @@ > 'data': {'status': 'MigrationStatus'}} > =20 > ## > +# @COLO_EXIT > +# > +# Emitted when VM finishes COLO mode due to some errors happening or > +# the request of users. s/the/at the/ > +# > +# @mode: @COLOMode describing which side of VM is exit. Maybe: @mode: Which COLO mode the VM was in when it exited. > +# > +# @reason: @COLOExitReason describing the reason of colo exit. @reason: describes the reason for the COLO exit. > +# > +# @error: #optional, error message. Only present on error happening. > +# > +# Since: 2.5 > +## > +{ 'event': 'COLO_EXIT', > + 'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason', '*error': '= str' } } Other than typos, the interface seems okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sxlGgnRandMIIjDAkRh9dNEO0iKtfmbo9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWT5WSAAoJEKeha0olJ0NqmkwH/2TNzkuGdx76PH9T7ZHoJ5le IrRZan+E/RKk6EofubFQuOuU7aGmoZPom4daeVhRC8grlx1wvTAjGz5sqQ4hAAWV TEQKdBJkAUE12tVRR1oKriil+1pgiouTdi1gcTMO3kXmX89kcbt92QXDAgUYXj7o 4LwowvD4T3+DRcVKqLfHTsOIO2aauRuW2zrHFAGfCIXXt+9i+tqUXX6cRkAUH1GE vHN6kjtybdPaMnrMRydCHVkeMN0Fu/cQxHZwZuVm+2do8jCjlObTKUwKhPAJ6lDG JgeGT2FmZXt76CPRmSMOB6jBn8vdpg9hg1qdmcwWMpvN+/C2An4ytkYvySpP53I= =G9Jx -----END PGP SIGNATURE----- --sxlGgnRandMIIjDAkRh9dNEO0iKtfmbo9--