From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzuVA-00038j-DU for qemu-devel@nongnu.org; Fri, 20 Nov 2015 17:49:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzuV7-00087B-5r for qemu-devel@nongnu.org; Fri, 20 Nov 2015 17:49:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzuV6-000871-UD for qemu-devel@nongnu.org; Fri, 20 Nov 2015 17:49:53 -0500 References: <1447836791-369-1-git-send-email-eblake@redhat.com> <1447836791-369-35-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <564FA389.5030003@redhat.com> Date: Fri, 20 Nov 2015 15:49:45 -0700 MIME-Version: 1.0 In-Reply-To: <1447836791-369-35-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EUQ7iC2Vrf4wBgqcWQQ9BovO1nRg8PvO1" Subject: Re: [Qemu-devel] [PATCH v12 34/36] qapi: Add positive tests to qapi-schema-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EUQ7iC2Vrf4wBgqcWQQ9BovO1nRg8PvO1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/18/2015 01:53 AM, Eric Blake wrote: > Add positive tests to qapi-schema-test for things that were > made possible by recent patches but which caused compile errors > due to collisions prior to that point. The focus is mainly on > collisions due to names we have reserved for qapi, even though > it is unlikely that anyone will want to abuse these names in > actual .json files. >=20 > The added tests includes: > Use of a member name ending in 'Kind' or 'List' [1, 3] Violates our coding convention of all lower case, so not worth testing. > Use of a type name starting with 'has_' [1, 4] Ditto. > Use of a type named 'u' [1, 5] Ditto. > Use of a union branch name of 'u' [2, 5] > Use of a union branch name starting with 'has_' [2, 4] Leaving just these two feels pretty weak. I think I'll just drop this patch from my queue entirely (it was great at proving that recent layout improvements worked, but it's not the end of the world to lose it entirely, especially now that v13 is starting to enforce naming conventions except for a few whitelisted names, and I don't want to make the whitelist longer just for the testsuite). >=20 > [1] Never broken, but could break if reservations are too strict > [2] Broken prior to commit e4ba22b > [3] See reservations in commit 4dc2e69 and 255960d > [4] See reservations in commit 9fb081e > [5] See reservation in commit 5e59baf >=20 > Not worth testing here: we no longer have a collision with a > member named 'base' (commit ddf2190), with a branch named > 'type' (commit e4ba22b), or with an alternate member named > 'max' (previous commits); these names were more accidental > namespace pollutions than intentional reservations. >=20 > Signed-off-by: Eric Blake >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EUQ7iC2Vrf4wBgqcWQQ9BovO1nRg8PvO1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWT6OJAAoJEKeha0olJ0NqxkgH/13lX+L9pcEb4QNacUA0CFOC i9W5G26AJa5liiwNH6IRSIFfqowu6+ly9p5Tf5qq1h7hiMSQKdS9aGiigwNBB8xY 3FmXG8rGacInfKaZEhQJtrYxozqkZISeeyhd4beDaV4nX7fRZGl8VEa0ZdCicr5D HuVWcrak+nBTApbvU7xAr27eP/MMpDwC9y1cd6rqUkxWhZ9xZUHewDsYCwKnnXyT k/WwSYBQc4wNgs3E1/B+ggmoI2ZBE6iA94swupfbaFpvr3F0Wlk177Y0YUlrpXP2 G3JrpLQ9itqXo5EVNa/94MS24M2Y4UaoUYBqA+3hc1QzGwewmsh2NwPOH1Up3ik= =TMBO -----END PGP SIGNATURE----- --EUQ7iC2Vrf4wBgqcWQQ9BovO1nRg8PvO1--