From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GODGF-0007Ry-FQ for qemu-devel@nongnu.org; Fri, 15 Sep 2006 08:57:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GODGB-0007RO-RB for qemu-devel@nongnu.org; Fri, 15 Sep 2006 08:57:39 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GODGB-0007RL-ID for qemu-devel@nongnu.org; Fri, 15 Sep 2006 08:57:35 -0400 Received: from [64.233.182.189] (helo=nf-out-0910.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GODIL-00016o-Va for qemu-devel@nongnu.org; Fri, 15 Sep 2006 08:59:50 -0400 Received: by nf-out-0910.google.com with SMTP id p46so2823981nfa for ; Fri, 15 Sep 2006 05:57:34 -0700 (PDT) Message-ID: <564d96fb0609150557v266bfe9do9a9e5e92f1949965@mail.gmail.com> Date: Fri, 15 Sep 2006 09:57:33 -0300 From: "=?UTF-8?Q?Rafael_Esp=C3=ADndola?=" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_5125_25488351.1158325053830" Subject: [Qemu-devel] [PATCH] avoid creating a circular list of cpus Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_5125_25488351.1158325053830 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline The attached patch avoids creating a circular list of cpus in do_fork. Currently, cpu_init returns a pointer to the last element of the list. This element is then overwritten by memcpy, including the cpu_index and next_cpu fields. The patch simply restores these fields to the correct values. The circular list causes a test program to halt when cpu_exec_init is called again. Best Regards, Rafael ------=_Part_5125_25488351.1158325053830 Content-Type: application/octet-stream; name=list.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_es4kgitb Content-Disposition: attachment; filename="list.patch" SW5kZXg6IGxpbnV4LXVzZXIvc3lzY2FsbC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2Vz L3FlbXUvcWVtdS9saW51eC11c2VyL3N5c2NhbGwuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43 NQpkaWZmIC11IC1yMS43NSBzeXNjYWxsLmMKLS0tIGxpbnV4LXVzZXIvc3lzY2FsbC5jCTI3IEp1 biAyMDA2IDIxOjA4OjEwIC0wMDAwCTEuNzUKKysrIGxpbnV4LXVzZXIvc3lzY2FsbC5jCTE1IFNl cCAyMDA2IDEyOjQ1OjIyIC0wMDAwCkBAIC0xNjE2LDYgKzE2MTYsNyBAQAogICAgIFRhc2tTdGF0 ZSAqdHM7CiAgICAgdWludDhfdCAqbmV3X3N0YWNrOwogICAgIENQVVN0YXRlICpuZXdfZW52Owor ICAgIGludCBjcHVfaW5kZXg7CiAgICAgCiAgICAgaWYgKGZsYWdzICYgQ0xPTkVfVk0pIHsKICAg ICAgICAgdHMgPSBtYWxsb2Moc2l6ZW9mKFRhc2tTdGF0ZSkgKyBORVdfU1RBQ0tfU0laRSk7CkBA IC0xNjI3LDcgKzE2MjgsMTMgQEAKICAgICAgICAgZmlyc3RfdGFza19zdGF0ZSA9IHRzOwogICAg ICAgICAvKiB3ZSBjcmVhdGUgYSBuZXcgQ1BVIGluc3RhbmNlLiAqLwogICAgICAgICBuZXdfZW52 ID0gY3B1X2luaXQoKTsKKyAgICAgICAgY3B1X2luZGV4ID0gbmV3X2Vudi0+Y3B1X2luZGV4Owog ICAgICAgICBtZW1jcHkobmV3X2VudiwgZW52LCBzaXplb2YoQ1BVU3RhdGUpKTsKKyAgICAgICAg Ly9uZXdfZW52IGlzIHRoZSBlbmQgb2YgdGhlIGxpc3QKKyAgICAgICAgbmV3X2Vudi0+bmV4dF9j cHUgID0gTlVMTDsKKyAgICAgICAgbmV3X2Vudi0+Y3B1X2luZGV4ID0gY3B1X2luZGV4OworCisK ICNpZiBkZWZpbmVkKFRBUkdFVF9JMzg2KQogICAgICAgICBpZiAoIW5ld3NwKQogICAgICAgICAg ICAgbmV3c3AgPSBlbnYtPnJlZ3NbUl9FU1BdOwo= ------=_Part_5125_25488351.1158325053830--