Re: [PATCH v4] vfio: Add property documentation

[Anthony Krowiak <akrowiak@linux.ibm.com>]

On 2/17/25 12:34 PM, Cédric Le Goater wrote:
> Investigate the git history to uncover when and why the VFIO
> properties were introduced and update the models. This is mostly
> targeting vfio-pci device, since vfio-platform, vfio-ap and vfio-ccw
> devices are simpler.
>
> Sort the properties based on the QEMU version in which they were
> introduced.
>
> Cc: Tony Krowiak <akrowiak@linux.ibm.com>
> Cc: Eric Farman <farman@linux.ibm.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>
>   Should we introduce documentation for properties like the kernel has
>   in Documentation/ABI/*/sysfs-* ?
>
>   Changes in v4:
>
>   - Latest improvements from Alex
>
>   Changes in v3:
>
>   - Re-organized the vfio-pci properties based on the QEMU version in
>     which they were introduced
>   - Added property labels
>   - Improved description as suggested by Alex, Tomita and Corvin
>
>   Changes in v2:
>
>   - Fixed version numbers
>   - Fixed #ifdef in vfio/ccw.c
>   - Addressed vfio-pci-nohotplug
>   - Organize the vfio-pci properties in topics
>
>   hw/vfio/ap.c       |   9 ++++
>   hw/vfio/ccw.c      |  15 ++++++
>   hw/vfio/pci.c      | 125 +++++++++++++++++++++++++++++++++++++++++++++
>   hw/vfio/platform.c |  24 +++++++++
>   4 files changed, 173 insertions(+)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 30b08ad375d5ecae886c5000fbaa364799fe76d0..c7ab4ff57ada0ed0e5a76f52b5a05c86ca4fe0b4 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -257,6 +257,15 @@ static void vfio_ap_class_init(ObjectClass *klass, void *data)
>       dc->hotpluggable = true;
>       device_class_set_legacy_reset(dc, vfio_ap_reset);
>       dc->bus_type = TYPE_AP_BUS;
> +
> +    object_class_property_set_description(klass, /* 3.1 */
> +                                          "sysfsdev",
> +                                          "Host sysfs path of assigned device");
> +#ifdef CONFIG_IOMMUFD
> +    object_class_property_set_description(klass, /* 9.0 */
> +                                          "iommufd",
> +                                          "Set host IOMMUFD backend device");
> +#endif
>   }
>   
>   static const TypeInfo vfio_ap_info = {

For ap.c:
Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>

>