From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0qnh-0000z8-JX for qemu-devel@nongnu.org; Mon, 23 Nov 2015 08:04:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0qne-000341-Dj for qemu-devel@nongnu.org; Mon, 23 Nov 2015 08:04:57 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:55880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0qne-00033g-3t for qemu-devel@nongnu.org; Mon, 23 Nov 2015 08:04:54 -0500 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Nov 2015 13:04:51 -0000 References: <1448024079-20808-1-git-send-email-bharata@linux.vnet.ibm.com> <20151123115433.GK5034@andariel.pipo.sk> From: Christian Borntraeger Message-ID: <56530EEE.7050206@de.ibm.com> Date: Mon, 23 Nov 2015 14:04:46 +0100 MIME-Version: 1.0 In-Reply-To: <20151123115433.GK5034@andariel.pipo.sk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa , Bharata B Rao Cc: agraf@suse.de, aik@ozlabs.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au On 11/23/2015 12:54 PM, Peter Krempa wrote: > On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: >> This patchset adds CPU hotplug support for sPAPR PowerPC guests using >> device_add and device_del commands >> >> (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 > > Is there a reason why this uses 'device_add' rather than the 'cpu_add' > command? Libvirt uses two separate approaches already. Due to legacy > reasons we support the HMP 'cpu_set' command, and lately we added > support for QMP 'cpu-add'. Using device_add here will introduce a > different approach and will require yet another compatibility layer in > libvirt to support this. s390 and powerpc both started with cpu_add patches. Andreas Faerber suggested then to only implement device_add. This was apparently discussed at the last KVM forum. Christian